Posts: 5,174
Joined: Jan 2010
Reputation:
97
Kib
Team-Kodi Member
Posts: 5,174
I'll check it out when I get back from Venice on Saturday
Posts: 378
Joined: Jan 2011
Reputation:
27
Working on cleaning up all the invalid includes references. I think I've got most of them, just scanning through the skinning tool as well as the XBMC logs to verify.
Posts: 5,174
Joined: Jan 2010
Reputation:
97
Kib
Team-Kodi Member
Posts: 5,174
Your work has been awesome, bumpaneer, and is much appreciated! Just landed at Amsterdam airport, will be home late tonight but tomorrow will be looking at Neon again.
Posts: 5,174
Joined: Jan 2010
Reputation:
97
Kib
Team-Kodi Member
Posts: 5,174
2014-03-08, 22:03
(This post was last modified: 2014-03-08, 22:17 by Kib.)
Just worked my way through your open pull request on the train and accepted it. Could you add the stuff you have done afterwards to a new PR so I can review it tomorrow ?
EDIT: Nevermind- github on phone failed to update so I didn't see you added them. Nice work!
Posts: 378
Joined: Jan 2011
Reputation:
27
Hmmm...either I'm doing something wrong, or the pull request hasn't been accepted maybe? When I create a new pull request it's still trying to include the previous round of commits as well. This is the first time I've branched and made my changes there, so its likely I'm doing something wrong.
Posts: 226
Joined: Mar 2010
Reputation:
4
Right i'm sorry gents i've given up on trying to sort the built in tv guide, no matter what i change i can't get the day labels to move.
I'm not really sure what else i can do to help at the moment.
sorry i can't be of more help.
Oh and great work Kib and Bumpaneer
Posts: 5,174
Joined: Jan 2010
Reputation:
97
Kib
Team-Kodi Member
Posts: 5,174
Sooner rather than later. I'm working on getting it in the official skin development repo
Posts: 5,174
Joined: Jan 2010
Reputation:
97
Kib
Team-Kodi Member
Posts: 5,174
2014-03-13, 00:27
(This post was last modified: 2014-03-13, 00:28 by Kib.)
Bumpaneer, instead of creating a list of view options that were broken, I ended up fixing most.
Nice work on the picture optimisation by the way.
Posts: 5,174
Joined: Jan 2010
Reputation:
97
Kib
Team-Kodi Member
Posts: 5,174
2014-03-13, 09:32
(This post was last modified: 2014-03-13, 09:32 by Kib.)
Hey I slept for at least 4 hours.
I finally had a little bit of time last evening to get some skinning done.
In the back of my mind I thought I would be working at home today. Just before sleeping however, I remembered I had to visit a customer which means to get up at 6 AM.
:/