Posts: 17,418
Joined: Aug 2007
Reputation:
590
Hitcher
Team-Kodi Member
Posts: 17,418
Why is it necessary to click OK when adjusting the start rating either up or down?
I'm trying to do away with this by sending an onclick action to the OK button but this closes the song info screen.
Thanks.
Posts: 26,215
Joined: Oct 2003
Reputation:
187
I believe it's because it's only stored in the database on save of the dialog, rather than on the action itself. Does the dialog have a "Cancel" button? If so, it makes sense this way. If not, then sure, it could be done on change of the item (though maybe via a delayed callback to save hitting the database on-thread).
Posts: 17,418
Joined: Aug 2007
Reputation:
590
Hitcher
Team-Kodi Member
Posts: 17,418
2014-02-25, 23:57
(This post was last modified: 2014-02-26, 00:04 by Hitcher.)
Yes it does have a cancel button but the whole process seems a bit long-winded when there are only 6 possible values (0-5).
Thanks for the explanation though.
EDIT: Can a song's rating be altered from MyMusicNav?
Posts: 15,263
Joined: Jan 2009
Reputation:
727
ronie
Team-Kodi Member
Posts: 15,263
i'm not sure how it's done on the musicosd, but you can change the songrating there without the need to ok/cancel.
Posts: 26,215
Joined: Oct 2003
Reputation:
187
It could, but we'd have to kill the cancel button.
Posts: 3,660
Joined: Feb 2008
Reputation:
93
Jeroen
Team-Kodi Member
Posts: 3,660
Can't say I really see the point of the cancel button actually. What is it that we're cancelling in this window? We're not editing anything (aside from the rating, but that is covered by the above discussed method) Basically it's a just a close button, right? That function can be performed by the Ok button too I would think.
Posts: 26,215
Joined: Oct 2003
Reputation:
187
It's covering the rating, yes.
Posts: 1,585
Joined: Nov 2007
Reputation:
44
wyrm
Skilled Skinner
Posts: 1,585
Hitcher,
I have been watching this thread for a while and thought I should give my code a spring clean by adding your code above, unfortunately my code does not seem to be working. Would you mind posting a link to your DialogSongInformation so that I can take a look and see why my activatewindow part of the code does not bring the dialog back up again.
Also, do you drop the "OK" and "Cancel" buttons completely from the code, or are you just not showing them?
Wyrm (xTV-SAF)
If required a FULL debug log can now be submitted from the skin in settings->skin settings->support. Or follow instructions
here if you can't access skin settings.
FAQ's located at :-
http://kodi.wiki/view/Add-on:AppTV