2014-02-27, 14:24
Found a bug in the current version of the moviedb moviescraper. More in particular in the regular expressions that match the imdb links in nfo files.
I discovered this bug when the scraper matched some erotic movie when it found http://us.imdb.com/Title?tt0020629/ in the nfo file. This was due to two problems in the code:
-The scraper didn't allow the use of tt in the Title? syntax. I changed the regexp so it now allows those (as IMDB themselves also allow it).
-The scraper minimally matched the IMDB url (due to the usage of * instead of +) anyways resulting in an empty IMDB id and thus the moviedb curl resulted in: http://api.tmdb.org/3/movie/tt?api_key=5...anguage=en ... an asian erotic movie. Fixed this by not allowing empty imdb ids in the regular expressions, they now require at least one digit.
More details in the commit below.
https://github.com/ScHAmPi/xbmc/commit/a...43e5ca91a7
Apparently a pull request for it doesn't make sense as the github doesn't have the current/up-stream version. Martijn suggested I post it to the forum so that's what I'm trying to do here:
https://github.com/xbmc/xbmc/pull/4284
I hope what I'm doing is correct... Just trying to help the community here.
I discovered this bug when the scraper matched some erotic movie when it found http://us.imdb.com/Title?tt0020629/ in the nfo file. This was due to two problems in the code:
-The scraper didn't allow the use of tt in the Title? syntax. I changed the regexp so it now allows those (as IMDB themselves also allow it).
-The scraper minimally matched the IMDB url (due to the usage of * instead of +) anyways resulting in an empty IMDB id and thus the moviedb curl resulted in: http://api.tmdb.org/3/movie/tt?api_key=5...anguage=en ... an asian erotic movie. Fixed this by not allowing empty imdb ids in the regular expressions, they now require at least one digit.
More details in the commit below.
https://github.com/ScHAmPi/xbmc/commit/a...43e5ca91a7
Apparently a pull request for it doesn't make sense as the github doesn't have the current/up-stream version. Martijn suggested I post it to the forum so that's what I'm trying to do here:
https://github.com/xbmc/xbmc/pull/4284
I hope what I'm doing is correct... Just trying to help the community here.