2014-04-10, 17:46
(2014-04-10, 15:18)ulion Wrote: fixed in the PR, you are right, it mixed a little my other modified code, just change the problem line to:Thanks, I'll have another try at compiling your commits tomorrow and run some tests to see how they compare to althekiller's.
SetCommonOptions(m_state);
would be enough for make it work.
(2014-04-10, 15:21)althekiller Wrote: @DBMandrake, I just pushed a fourth commit that should fix the issue you mentioned with the refactor commit.Thanks - I've just applied all four commits and compiled on the Mac - the connections do switch around properly now after each seek as they did before the refactor commit.
I'm going to do some real world testing using add-ons on the Mac tonight running this build, then do some more local network tests and single stepping tomorrow on windows to try to verify the changed logic in corner cases to make sure nothing else has been missed, but it's looking promising so far, and I do like the elegance of the recursive call to retry the request without multisession rather than duplicating lots of code.