Fade and delay
#1
Not sure how or what. But I think maybe delay is preventing fade from reaching 100% if combined with another.

Code:
<animation type="WindowOpen" reversible="false">
    <effect type="fade" start="1" end="100" time="1000" delay="500"/>
    <effect type="rotatey" start="1" end="0" time="100" center="640,360"/>
</animation>

In this example fade will go from 1% to 50%. Or could it be something else?

On Windows, nightly from couple of days ago.
Image [RELEASE] Metroid
Image [RELEASE] IrcChat
Reply
#2
(2014-04-19, 00:49)MassIV Wrote: Not sure how or what. But I think maybe delay is preventing fade from reaching 100% if combined with another.

Code:
<animation type="WindowOpen" reversible="false">
    <effect type="fade" start="1" end="100" time="1000" delay="500"/>
    <effect type="rotatey" start="1" end="0" time="100" center="640,360"/>
</animation>

In this example fade will go from 1% to 50%. Or could it be something else?

On Windows, nightly from couple of days ago.

I've noticed this before also: xbmc doesn't seem to factor in the delay time for an animation's duration when combined with another animation . The workaround I use is to create a dummy slide animation before it with time set to the entire length of the animation (delay + time) and this seems to force the animation to complete. For example:
PHP Code:
<animation type="WindowOpen" reversible="false">
    <
effect type="slide" start="0" end="0" time="1500"/>
    <
effect type="fade" start="1" end="100" time="1000" delay="500"/>
    <
effect type="rotatey" start="1" end="0" time="100" center="640,360"/>
</
animation
Arctic Fuse - Alpha now available. Support me on Ko-fi.
Reply
#3
This is a bug. ATM it works out the delay as the minimum of all delays and the length as the maximum of all the times regardless of the delay. But it doesn't work out the latter based on the former across different effects - i.e. in the above the length will be 1000ms and the delay will be 0ms, however the first effect will start at 500ms, so you'll get only the first half.

I'll do up a fix PR, but my concern would be that this would inadvertantly break behaviour for skins that might be relying on this (without knowing it?) Either way, once the fix is up and tested we can make the call on whether to hit Gotham or not!

Cheers,
Jonathan
Always read the XBMC online-manual, FAQ and search the forum before posting.
Do not e-mail XBMC-Team members directly asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting please make sure you read this first.


Image
Reply
#4
Fix is available here: https://github.com/xbmc/xbmc/pull/4580

EDIT: win32 build here: http://mirrors.xbmc.org/test-builds/win3...th_fix.exe

Please test and ensure nothing else breaks.
Always read the XBMC online-manual, FAQ and search the forum before posting.
Do not e-mail XBMC-Team members directly asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting please make sure you read this first.


Image
Reply
#5
Might not be related, but i'm seeing a fadelabel that is acting weird. Seems to flip every second for all <scrollspeed> under 40000, above that it just stops. And <pauseatend> looks like it is completely ignored.

Code:
        <control type="fadelabel">
            <label>a</label>
            <label>b</label>
            <scrollspeed>39000</scrollspeed>
            <pauseatend>39000</pauseatend>
        </control>
Image [RELEASE] Metroid
Image [RELEASE] IrcChat
Reply

Logout Mark Read Team Forum Stats Members Help
Fade and delay0