[marakew]

possible to post issue at forum?

i use pvr.hts plugin, while change client ip address, some channel not updated

fix below

xbmc/xbmc/pvr/channels/PVRChannel.cpp

Code:

bool CPVRChannel::UpdateFromClient(const CPVRChannel &channel)
{
  SetClientID(channel.ClientID());
  SetClientChannelNumber(channel.ClientChannelNumber());
  SetInputFormat(channel.InputFormat());
  SetStreamURL(channel.StreamURL());
  SetEncryptionSystem(channel.EncryptionSystem());
  SetClientChannelName(channel.ClientChannelName());

  CSingleLock lock(m_critSection);
-  if (m_strChannelName.empty())
-    SetChannelName(channel.ClientChannelName());
+   SetChannelName(channel.ChannelName());
  if (m_strIconPath.empty()||(!m_strIconPath.Equals(channel.IconPath()) && !IsUserSetIcon()))
    SetIconPath(channel.IconPath());

  return m_bChanged;
}

[xhaggi]

there is a pending pull request which solve the issue in a more suitable way.
https://github.com/xbmc/xbmc/pull/4412

[marakew]

i see
will waiting for pull
but i see the problem incorrect used the function ClientChannelName instead ChannelName

SetChannelName(channel.ClientChannelName());
vs
SetChannelName(channel.ChannelName());

[xhaggi]

we update from client so channel.ClientChannelName() is fine.

[xhaggi]

it's fixed in our nightly builds.