Bug [XBMCSubtitles] Problem with subs of movies that are stacked and rarred
#1
Bug 
I discovered a problem with getting the subtitles for movies that are both stacked and inside rar files.

My debug log:
http://xbmclogs.com/show.php?id=201582

The piece of code causing the initial problems is this in gui.py:
Code:
if ( movieFullPath.find("http") > -1 ):
      self.sub_folder = self.stream_sub_dir
      self.temp = True

    elif ( movieFullPath.find("rar://") > -1 ):
      self.rar = True
      movieFullPath = os.path.dirname(movieFullPath[6:])

    elif ( movieFullPath.find("stack://") > -1 ):
      self.stackPath = movieFullPath.split(" , ")
      movieFullPath = self.stackPath[0][8:]
      self.stack = True

That code doesn't take into account a case of stack and rar combined.

When using the example of the log above:
Code:
stack://rar://T:/Films/Cloud.Atlas.2012.BDRiP.XviD-AiHD/CD1/cloudatlasa-xvid-aihd.rar/cloudatlasa-xvid-aihd.avi , rar://T:/Films/Cloud.Atlas.2012.BDRiP.XviD-AiHD/CD2/cloudatlasb-xvid-aihd.rar/cloudatlasb-xvid-aihd.avi

The first elif puts the string below into the file path. Which is wrong for two reasons. First of all, it wrongfully assumes that "rar://" is what the string began with and chops off "stack:" instead of "rar://". And second, it doesn't take care of the fact that the path is a combined one of two cd's.
Code:
//rar://T:\Films\Cloud.Atlas.2012.BDRiP.XviD-AiHD\CD1\cloudatlasa-xvid-aihd.rar/cloudatlasa-xvid-aihd.avi , rar://T:\Films\Cloud.Atlas.2012.BDRiP.XviD-AiHD\CD2\cloudatlasb-xvid-aihd.rar

I don't know enough about the inner workings of the plugins and XBMC to fix it myself but I wanted to inform you guys anyways.

Hopefully someone can take a look at this and finds this post helpful.

Kind regards,
ScHAmPi.
Reply
#2
no partial logs and use xbmclogs.com
Read/follow the forum rules.
For troubleshooting and bug reporting, read this first
Interested in seeing some YouTube videos about Kodi? Go here and subscribe
Reply
#3
(2014-05-14, 22:46)Martijn Wrote: no partial logs and use xbmclogs.com

Fair enough and thanks for your response. Edited my post.
Reply

Logout Mark Read Team Forum Stats Members Help
[XBMCSubtitles] Problem with subs of movies that are stacked and rarred0