2014-07-14, 13:38
1. Offset menu handling
Ask yourself this question: what happens more often, a user wanting to return to the menu to change another setting or a user wanting to return to watching his/her movie after settings the subtitle offset?
When setting the subtitle offset, please make it so that pressing 'enter/ok' will close the subtitle offset menu and the main OSD menu.
Pressing 'back/backspace' can return you to the OSD menu.
2. Offset limits
Please accept this PR https://github.com/xbmc/xbmc/pull/4929
3. Autocorrect subtitles that keep getting out of sync
It happens all the time. You set the offset so that your subtitle is in sync after a few minutes it gets out of sync and gradually gets worse.
XBMC could calculate a factor by looking at your sync corrections and use this factor along the way to keep the subtitle in sync.
Ask yourself this question: what happens more often, a user wanting to return to the menu to change another setting or a user wanting to return to watching his/her movie after settings the subtitle offset?
When setting the subtitle offset, please make it so that pressing 'enter/ok' will close the subtitle offset menu and the main OSD menu.
Pressing 'back/backspace' can return you to the OSD menu.
2. Offset limits
Please accept this PR https://github.com/xbmc/xbmc/pull/4929
3. Autocorrect subtitles that keep getting out of sync
It happens all the time. You set the offset so that your subtitle is in sync after a few minutes it gets out of sync and gradually gets worse.
XBMC could calculate a factor by looking at your sync corrections and use this factor along the way to keep the subtitle in sync.