WIP Teletext improvements
#1
Current teletext implementation defaults to displaying 39 characters per row (columns 1-39) if there's no visible character found in column 0 of a teletext page. Some TV channels, for example SVT channels in Sweden, use column 0 for visible characters only in some pages but the layout is done for 40 characters. Column 0 is always supposed to be displayed even if it's blank to avoid jumping graphics. This can be achieved by changing m_RenderInfo.Show39 in CTeletextDecoder from true to false. I would prefer to simply always have Show39=false, but I suppose this could cause problems for someone else. Some options would be:

1. Simply change Show39 to false

2. Make Show39 a configurable setting

3. Try to make intelligent decision on 39 or 40 characters once based on full teletext stream and don't dynamically change for individual pages (probably not 100% reliable)

Options 1 & 3 would also help fix this problem:
http://trac.xbmc.org/ticket/15332

The first two screenshots below are with Show39=true and shows the jumping graphics. The last two screenshots are with Show39=false.

Image

Image

Image

Image
Reply
#2
I decided to take a stab at this myself and created a pull request: https://github.com/xbmc/xbmc/pull/5179

Maybe someone could move this post to "Development" forum?
Reply

Logout Mark Read Team Forum Stats Members Help
Teletext improvements0