2014-08-21, 23:43
Hi folks,
we found a bug which allows Kodi to connect to the LIRC socket multiple times.
We are using quite often the builtin-functions LIRC.Stop and LIRC.Start when we load an addon which has longer load time (so guests cannot hammer on the RC and we are having unexpected behavior afterwards).
Sometimes we run a LIRC.Start even if there was no LIRC.Stop before (e.g. if an addon is started by JSON).
We now found that Kodi is alwas creating a new connection to the LIRC unix domain socket and losing the previous socket information (thus it can never be freed again).
I now added the m_bInitialize variable to the if condition of the Initialize method and everything seems to be OK now.
I will post a PR in a few minutes (will post link here too).
I hope this OK for you guys ;-)
all the best,
philipp
PR opened: https://github.com/xbmc/xbmc/pull/5268
we found a bug which allows Kodi to connect to the LIRC socket multiple times.
We are using quite often the builtin-functions LIRC.Stop and LIRC.Start when we load an addon which has longer load time (so guests cannot hammer on the RC and we are having unexpected behavior afterwards).
Sometimes we run a LIRC.Start even if there was no LIRC.Stop before (e.g. if an addon is started by JSON).
We now found that Kodi is alwas creating a new connection to the LIRC unix domain socket and losing the previous socket information (thus it can never be freed again).
I now added the m_bInitialize variable to the if condition of the Initialize method and everything seems to be OK now.
I will post a PR in a few minutes (will post link here too).
I hope this OK for you guys ;-)
all the best,
philipp
PR opened: https://github.com/xbmc/xbmc/pull/5268
