Solved Kodi Helix crashing when seeking movies
#16
for the record: no need to clone, just add an additional remote to git. saves traffic on github Smile
Reply
#17
i'm sorry, but i have no knowledge about git. your suggestion makes no sense to me Wink
i just know to clone, clean up etc.

i'm a long long year dev myself, but never used git for anything, neither gdb. my larger projects were (sadly) not for linux platforms.
Reply
#18
ok, with your git it indeed seems to be much more stable now. but i still managed to crash kodi with seeking. i'll report back with details after dinner Wink
Reply
#19
so, here it is, gdb all threads backtrace and the xbmc log in debug mode:
https://drive.google.com/folderview?id=0...sp=sharing

The version from FernetMentas master branch is indeed MUCH more stable regardnig seeking. i had to seek forward and backward like mad until i managed to crash kodi.

it seems like there is a race condition with threads. there is some code not properly made thread safe and with bad luck or excessive seeking you can run into it.

i'm now away for some hours. but i will check later if there is something else i can do to help pinning this down.
at least i can give a little back with this to this great peace of software i enjoy for years Big Grin
Reply
#20
it crashes somewhere in mesa i965_dri.so whle deleting a texture

if (glIsTexture(pic->texture))
{
glDeleteTextures(1, &pic->texture); <---------------- here
glXDestroyPixmap(m_Display, pic->glPixmap);
XFreePixmap(m_Display, pic->pixmap);
}

so I fist ask the driver if the texture is valid, it. says yes, then it segfaults Sad not nice

can you reproduce this with trusty? utopic might be a bit too unstable currently. just to narrow it down.
Reply
#21
yes i could reproduce this with trusty when i had it. but i cannot anymore because i do not have the possibility to install it again, sorry.

note: utopic had until yesterday or so stil a much older graphics stack/driver. it still happend with it. but you see now the probplem after updating to the new one.

--------------------------------------------------------------------
EDIT:before this update it was i915 driver and not i965.
---------------------------------------------------------------------

sorry that i can't do more as it seems.

anyhow, i see that threads are started when seeking. not sure what they do so this may be a stupid question:
but could it be that you ask the driver for validity of the texture but when you actually use it it is a different one, altered by another thread?

the reason i ask is because it only seems to happen rarly (at least in your version) and only when seeking forward and backward like mad.

if it would be just a driver bug making a mistake about the validity then it should be reproducable even when using seek only rarly, like a normal usae case. or?
Reply
#22
only a single thread does access this. a problem may be that shared gl contexts in mesa is a mess. when did you last update to my branch. i changed the code above and explicitly set pic->pixmap to None.
Reply
#23
hmm, not sure, somewhere last night. but i had some issues here so i maybe messed up stuff (i mean my copy of your source).

mind tell we the file/line where you did the change and i can check if its there?
Reply
#24
https://github.com/FernetMenta/xbmc/blob....cpp#L2138
Reply
#25
yes i have that. and i tried to crash kodi. i didn't managed to crash it with seeking.

seems fixed.
Reply
#26
good to hear.

btw: currently I do long term tests with 1080i@50 using MCDI. I observe really strange things I can't explain with Trusty + kernel 3.16.1 + libva-intel-vaapi-driver fro mwsnipex ppa. today I went back to kernel 3.15.10 and haven't seen any issue for the last two hours.
Reply
#27
there's a new driver and libva in that ppa now. Lets hope it doesn't change for the worse Smile
Reply
#28
back again Smile

i am back to utopic stock libs again. i want to keep that until it is officially released and stabilized and then switching to oibaf or what ever i'm in the mood to experiment with Wink

anyhow, glad this issue is fixed and that i could somehow help with it.

now i gonna enjoy a nice movie with kodi. i use it as my all in one home entertainment, tv movies, music.
though living with the git version always causes sometimes trouble Big Grin
Reply
#29
just a final question on this topic:
is there an eta when the fixes are getting merged into kodi main master branch?
Reply
#30
ETA: asap.

Fernet is the main vaapi maintainer. So when real life allows.
First decide what functions / features you expect from a system. Then decide for the hardware. Don't waste your money on crap.
Reply

Logout Mark Read Team Forum Stats Members Help
Kodi Helix crashing when seeking movies1