Posts: 17,458
Joined: Aug 2007
Reputation:
591
Hitcher
Team-Kodi Member
Posts: 17,458
Awesome, thanks.
PS Anyone know what SubItem actually does?
Posts: 4,146
Joined: Jan 2008
Reputation:
40
I'd guess it was meant as an infobool to check whether or not the currently selected item is part of the container. Not sure if that makes sense ..
Always read the
online manual (wiki),
FAQ (wiki) and search the forum before posting.
Do not PM or e-mail Team-Kodi members directly asking for support. Read/follow the
forum rules (wiki).
Please read the pages on
troubleshooting (wiki) and
bug reporting (wiki) before reporting issues.
removed151214
Unregistered
removed151214
Unregistered
Posts: N/A
Just tested the patch on Mac - works brilliantly, and so much nicer than my hack
Even better, it means a script I can drop as soon as Kodi I* drops
Thanks for a great improvement to the skinning engine.
(edit: even better, I'm slowly trying to learn my way around Kodi's code, as I'm used to trying to fix problems myself wherever I can. Though I have very limited knowledge of low level languages, your patch is a great example I can use to learn more, and hopefully be able to contribute such fixes in a proper way in the future.)
Posts: 7,135
Joined: Oct 2012
un1versal
Out of Memory (1939–2016)
Posts: 7,135
I see
https://github.com/xbmc/xbmc/pull/5872 was merged, Though I see no skin chnages made yet for confluence. Just posting here as a reminder so it it isn't forgotten by ronie.
Posts: 7,135
Joined: Oct 2012
un1versal
Out of Memory (1939–2016)
Posts: 7,135
(2014-12-27, 15:17)phil65 Wrote: (2014-12-27, 14:49)uNiversal Wrote: I see https://github.com/xbmc/xbmc/pull/5872 was merged, Though I see no skin chnages made yet for confluence. Just posting here as a reminder so it it isn't forgotten by ronie.
Confluence doesnt need adjustments for that, it´s just an additional condition.
If you read PR comments that was said it would be added and it hasnt, so Im just reading what it says there.
Posts: 17,458
Joined: Aug 2007
Reputation:
591
Hitcher
Team-Kodi Member
Posts: 17,458
I think you're getting confused with me asking for it to be added to the 'Skin changes thread'.
Posts: 17,458
Joined: Aug 2007
Reputation:
591
Hitcher
Team-Kodi Member
Posts: 17,458
Also, it's for Kodi v15 not Helix.
Posts: 15,264
Joined: Jan 2009
Reputation:
728
ronie
Team-Kodi Member
Posts: 15,264
@uNiversal, please do me a favour and limit your suggestions / comments / contributions to areas you're knowledgeable about.
this will save me (and apparently i'm not the only one) a lot of annoyances and waste of time.