EDL (and ComSkip) integration

jmarshall Wrote:Not sure I can give you any hints, other than to dump a breakpoint in CGUIWindowFullScreen::OnAction() and checking that it goes into that function. Work your way back to CApplication::OnKey() until you find the issue.

Cheers,
Jonathan

Video is not fullscreen in dummyvideoplayer, so I'm stuck in CGUIWindowVideoFiles. I see render code in dummyvideoplayer, but it's not used.
Why is this?

because it's not fullscreen?

Tab toggles to fullscreen IIRC.

jmarshall Wrote:because it's not fullscreen?

Tab toggles to fullscreen IIRC.

Ah, that simple!
I expected 'full screen' video by default.

Yeah - the dummy video player is more "dummy" than video player, so the fullscreen switch doesn't happen by default for the basic reason that I've been too lazy to look into it!

When using EDL, standard seeking can give a problem when the seek target is inside a cutpoint. When seeking backward inside a cutpoint, mplayer will jump forward again.

I wrote a seek compensator, but I don't know how to interpret the following code:


Is it possible not to know the total movie time? Of won't this situation occur for normal movies?
(I must admit I didn't know about percentage seeking. As long as I know of I'm seeking in seconds. )

Have you had time (and interest) to look at using the EDL class for the DVDPlayer video-player core?
http://xboxmediacenter.com/wiki/index.ph...evelopment
http://forum.xbmc.org/showthread.php?tid=10216
http://xboxmediacenter.com/wiki/index.ph..._Libraries

Gamester17 Wrote:Have you had time (and interest) to look at using the EDL class for the DVDPlayer video-player core?
http://xboxmediacenter.com/wiki/index.ph...evelopment
http://forum.xbmc.org/showthread.php?tid=10216
http://xboxmediacenter.com/wiki/index.ph..._Libraries

Not yet, but the code is pretty generic and will easily integrate.
If I finish it, I can check out DVDPlayer integration. Maybe we can do something smart with chapters and scenemarkers, so we can use chapters for non-DVD movies.

DrDDT Wrote:Maybe we can do something smart with chapters and scenemarkers, so we can use chapters for non-DVD movies.

That would be great, some non-DVD video containers such as MKV (Matroska), OGM, NUT, and DIVX (that is .divx and not .avi) do have chapter support. I believe FFmpeg which the DVDPlayer uses does have support for chapter markers jumping in some of those containers (I think at least for MKV and OGM). Though I'm not sure if it has been implemented and enabled in the DVDPlayer(?)

DrDDT Wrote:When using EDL, standard seeking can give a problem when the seek target is inside a cutpoint. When seeking backward inside a cutpoint, mplayer will jump forward again.

I wrote a seek compensator, but I don't know how to interpret the following code:

Code:

//If current time isn't bound by the total time,
    //we have to seek using absolute percentage instead
    if( GetTime() > iTime * 1000 )
    {
      SeekPercentage(GetPercentage()+percent);
    }

Is it possible not to know the total movie time? Of won't this situation occur for normal movies?
(I must admit I didn't know about percentage seeking. As long as I know of I'm seeking in seconds. )

I'll ignore this for now.

Hi,

I'm pretty much done with upgrading EDL features by writing a seperate class for it, and I'm thinking of supplying a patch and move on to something else.

I played around a lot, added/removed features, and for now I ended up with the following features:

- Read the following EDL formats:
EDL
ComSkip .txt (with framerate, like Comskip generates)
VideoRedo
- Cache EDL file to disk and pass it to MPlayer.
- Adjust seeking so cutpoints are skipped.
- Support for SceneMarkers for the following formats:
VideoRedo
EDL (I introduced a type '3' for scenemarkers)
- Support for SceneMarkers seeking, added keycode.
(I mapped this to the >| and |< keys on my remote)
- added 'edl:y|n to video status screen.

The following is implemented, but disabled:
- Cutpoint seeking (only usefull for cutpoint editing?)
- Automatically create Bookmarks for every SceneMarker.
(Didn't even test this, because commercial skippers generate a lot of scenemarkers).
- Reading of 'VDR' format, because it's not very well specified.

Not implemented:
- Compensation for cutpoint when movie length is unknown and percentage seeking is used.
- Visual cutpoints/scenemarkers on video progress bar.

Problems/Questions:
- The readers now stop reading at the first format error, and invalidate the EDL. This might be a problem for showanalyzer, I get a lot of strange format errror with this tool. Comskip output is fine.
- Should I be able to go to a scenemarker inside a cutpoint? For now, you can.
- Should one be able to seek inside a cutpoint, and just jump over a cutpoint beginning to avoid bouncing?
- Any other missing features, or should I drop features?
- The code needs more testing. I can only test using XBMC_PC and release code on XBOX, using my limited usage pattern.