EDL (and ComSkip) integration

No idea - try it in regular mplayer

How do I add a 'buttonhandler'?
Say I want to add a 'skip to next cutpoint/scene' button, and use it to seek to the next/previous cutpoint/scene marker?

I have code ready to generate the correct seek position.

first, define the appropriate action. then map it in keymap. finally handle the action in OnAction() whereever you want it (most like CGUIWindowFullscreen).

actions are defined in guilib/Key.h

ButtonTranslator.cpp maps it to a 'human' name which you use in keymap.xml

spiff Wrote:first, define the appropriate action. then map it in keymap. finally handle the action in OnAction() whereever you want it (most like CGUIWindowFullscreen).

actions are defined in guilib/Key.h

ButtonTranslator.cpp maps it to a 'human' name which you use in keymap.xml

Okay, but how does for example <skipminus>SkipPrevious</skipminus>
map to an action in key.h?

ButtonTranslator.cpp does that.

Another option is just re-using the "Next Chapter/Previous Chapter" actions that already exist (in the DVD player). You'd have to implement an OnAction() in mplayer I think to do this.

Next problem:

I'm trying to debug seeking in a movie using xbmc_pc.
I see the time running of the movie I'm trying to play, but the buttons I defined are not handled by CGUIWindowFullScreen somehow.
Is another class handling these buttons, since the movie is not really playing?

The next/previous chapter seeking is done by the DVDPlayer, which should be working on XBMC_PC, at least for some videos.

If it's not, you can make a quick change to PlayerCoreFactory.cpp to make sure it's being used.

If a video is playing the action gets sent to the player first for processing (so it can do dvd menu stuff for instance) and only if not handled (returns false) drops back to CGUIWindowFullScreen.

Cheers,
Jonathan

jmarshall Wrote:The next/previous chapter seeking is done by the DVDPlayer, which should be working on XBMC_PC, at least for some videos.

If it's not, you can make a quick change to PlayerCoreFactory.cpp to make sure it's being used.

If a video is playing the action gets sent to the player first for processing (so it can do dvd menu stuff for instance) and only if not handled (returns false) drops back to CGUIWindowFullScreen.

Cheers,
Jonathan

I'm working on EDL integration with MPlayer, or in XBMC_PC, Dummyvideoplayer. I can see the correct keycodes in the debugscreen, but the OnAction in Dummyvideoplayer is not triggered somehow.

Not sure I can give you any hints, other than to dump a breakpoint in CGUIWindowFullScreen::OnAction() and checking that it goes into that function. Work your way back to CApplication::OnKey() until you find the issue.

Cheers,
Jonathan

jmarshall Wrote:Not sure I can give you any hints, other than to dump a breakpoint in CGUIWindowFullScreen::OnAction() and checking that it goes into that function. Work your way back to CApplication::OnKey() until you find the issue.

Cheers,
Jonathan

Ok, I'll try that.