Posts: 12,706
Joined: Nov 2003
Reputation:
129
spiff
Team-Kodi Member
Posts: 12,706
because we need to store the scraper data somewhere (namely in the database)? and if you had a look at that change you'd see it wasnt exactly a large change.. you dont want to see the results of parsing the xml all the time, it would make everything crawl.
Posts: 12,706
Joined: Nov 2003
Reputation:
129
spiff
Team-Kodi Member
Posts: 12,706
so do something about it - patch welcome
Posts: 26,215
Joined: Oct 2003
Reputation:
187
Indeed - a patch would be most welcome. I'm more than happy to give directions through the code, as are any devs.
Cheers,
Jonathan
Posts: 1,331
Joined: Jan 2008
Reputation:
3
rwparris2
Team-XBMC Python Developer
Posts: 1,331
Ok, so I downloaded the source file, took a look around, and... my respect for you guys just doubled. Good god there is a lot to look through, and it doesn't help that my only programming exposure is light php & xbmc-specific python. c++ is clearly a whole different beast.
Because of my total lack of knowledge around the code, I doubt I'll be able to get anything done, but maybe just MAYBE I'll learn something while trying.
Would either of you devs like to point me in the right direct of which files I'll need to be going through to achieve something like this? Obv the database & thumbs & some of the gui views stuff, but, I'm hoping for something more specific.
Also if anyone has any c++ tutorial/learning sites they could recommend that would be great too.
Posts: 26,215
Joined: Oct 2003
Reputation:
187
Certainly - I'd hate to get dumped into our code at this point - it was tricky enough when I started, and there was far less code back then!
The thumb setting/caching stuff is done mainly in CFileItem::SetUserVideoThumb() and CFileItem::SetCachedVideoThumb() + it's miscellaneous routines (such as GetFileTBN() etc.)
The idea is you'd have to be able to set + get an alternate version, caching it differently.
In the SetCachedVideoThumb() you'd then set the normal thumb and set the alternate thumbs in a property (SetProperty("name_of_property", "value_to_set")).
Skinners could then retrieve the property and display that if it suits them better.
Have a read through the CFileItem routines and then feel free to ask any specific questions.
Cheers,
Jonathan
Posts: 233
Joined: Jan 2009
Reputation:
0
jtap06
Senior Member
Posts: 233
Thats a good idea...any one know if this can be done?
Posts: 1,545
Joined: Oct 2008
Reputation:
31
fekker
Posting Freak
Posts: 1,545
2009-03-13, 03:25
(This post was last modified: 2009-03-13, 03:28 by fekker.)
this option doesn't currently exist, but it's a great idea
something like
movie-wide.tbn
<filename>-wide.tbn
Maybe this would be a good time to add support for hi-resolution images as well
movie-big.tbn
<filename>-big.tbn
(and for tvshows as well for the show image)
be a great feature request
Posts: 170
Joined: Apr 2007
Reputation:
0
mots
Senior Member
Posts: 170
2009-11-01, 15:32
Hey, I have a little problem: As some skins use banners, and others posters I always have to replace the files when switching skins... So how about having support for both simultaniously? For example a banner.jpg and a poster.jpg?