(2016-09-22, 17:10)Razze Wrote: @keymap issue, in all honestly if somebody can build an api in kodi itself it will solve all our problems here. There just needs to be someone to step up and do it. We would all be really greatful.
I entirely agree, but until then users should be able to make an informed decision (as in, the add-on and third party repo must make a very clear warning about doing something like editing a keymap) and decide for themselves if the risk is worth it. I don't see that as any more of an issue than some of Kodi's own features which are considered advanced, including path substitution, MySQL, various manual video settings, and others which can result in an unusable system if set incorrectly.
Perhaps this all comes down to a disagreement about where the line is drawn for "minor" and "major" risk? I'm willing to compromise on that, but the whole idea of this is a repo for users who know what they're doing, and not the fly-by-night-just-works users.
Quote:I think he was refering to the whole proposed repo and not specifically to robs addons. And some big addon that always comes to my mind in that regard is emby, which we had to turn down, unfortunatly.
But I'm still seeing people posting about broken databases due to emby from time to time. And while that might be okay for users like you and me, I don't think we're the user norm.
Since the proposed repo would most likely contain most or all of rob's add-ons, including the ones that change keymaps, it makes little difference about which specific repo is being talked about. I agree, this wouldn't be for the normal user, but I think ronie is making thinly-veiled threats that "this" repo (whatever it will be named, hence quotes), would be banished in the same way that rob's repo was.
I'm hoping that is not the case, and that something like keymap hacks (which are not desired and are indeed messy hacks) are not seen as "bannable dangerous" (for a lack of better words). I'm hoping it is only about the Mutagen issue, where I agree that it would just be easier for rob to change the add-on ID for his fork. I hope I am wrong, and that ronie was not trying to make any kind of threats.
Maybe a rule of "this" repo would be to require that all add-ons have a repo-specific prefix, to avoid any conceivable conflict, no matter how unlikely, simply as a compromise. If that is what it takes, I am fine with that.
Quote:Your right, we will try to not negotiate, because if we negociate and trust one dev it pretty much opens the door for others, maybe even on other unrelated rules.
I'm sure in any situation you can find an extreme example, but it is part of the established add-on rules that occasional reasonable exceptions and "softening" can sometimes happen. It doesn't have to actually happen, though, and one of the biggest issues seems to be the flat refusal to even discuss the issue with the add-on author in question (not just in rob's case). The current prime example being the discussion with deleting Mutagen. A reasonable compromise to that conflict, and a compromise that actually follows the rules. However, two add-on reviewers already seemed to reject it.
I don't think anyone is expecting a free pass for hacky behavior. Even for keymaps, I don't entirely agree with the situation, but I can respect the decision to not allow just any add-on to change that map. At least not in the official repo.
Quote:I'm not really sure about this part, as i've only ready about automatic reviews. Should be pretty easy to fool (surprise me please) and get some harmful code onto some kodi machines.
I assure you, we won't do an automatic review system. I think zag was talking about some pre-checks to help streamline submission, but that is all. Allowing some kind of automatic system would make it no better than super repo, which has serious security concerns that are independent of the piracy issue.
At this point this thread exists to hammer out all of the details. If they can't be hammered out, if there isn't a good review process in place, then the repo won't happen. At least, I would not want any part in something like that. Don't forget, even since before I was ever a member of Team Kodi I was one of the most active users on the forums, so that's well over five years I've had of obsessively helping users. Now it's also part of my profession. I don't want to do anything to increase my own work burden, or anyone else's ;)
For what it's worth, thank you, Razze, for discussing the points raised. Even if we don't agree on everything about this repo stuff, it seems that you are actually giving it some fair consideration and are willing to be constructive with any potential issues. I really appreciate it.
