Posts: 7,172
Joined: Dec 2003
Reputation:
4
kraqh3d
Retired Developer
Posts: 7,172
sho, can you provide an example video smartplaylist that produces output with duplicate genres?
Posts: 7,172
Joined: Dec 2003
Reputation:
4
kraqh3d
Retired Developer
Posts: 7,172
re: the adult stuff ... why not both a flag in the database, and a new content type? by making it a new content type, the scrapers can also be hidden.
Posts: 7,172
Joined: Dec 2003
Reputation:
4
kraqh3d
Retired Developer
Posts: 7,172
right. if "hide adult content" is enabled in settings, then the scrapers and the content they've previously found can both be hidden.
Posts: 4,132
Joined: May 2004
Reputation:
4
sho
Team-XBMC Member
Posts: 4,132
2008-07-01, 17:28
(This post was last modified: 2008-07-01, 17:41 by sho.)
Bug for both music and video smart playlists.
When you browse for a playlist to include / exclude, you have to select and open a playlist and then go back via ".." before you are allowed to choose a playlist (ie the OK button does not get selectable before you go through this ceremony).
Also the Browse button is not highlighted (active) when Playlist is the argument, you can get around it by clicking the text field. (Neither does it for Title, by design or not?)
Posts: 26,215
Joined: Oct 2003
Reputation:
187
kraqh3d: Yes, that's the idea. A new content type will be used in the set content dialog, but I'm not sure we need to push it all the way through (basically we don't want to be doing a whole bunch of "if (strContent.Equals("adult") || strContent.Equals("video"))" stuff if we can avoid it, though ofcourse a function could always be added to wrap that up (eg info.IsMovie()). I suspect that would be the easiest way to get things done, but I don't think we want to duplicate the tables in the db - perhaps we could have a separate view though?
sho: The idea with playlist was it only made sense to allow them to choose one (i.e. instead of typing in the name), but yes, this is somewhat inconsistent now that we have the browse button (we didn't always). Not sure how the filebrowser dialog is working on that front, but it sounds like there's some issue there as well? We may be able to do it just via the select dialog in the future.
Cheers,
Jonathan
Posts: 4,132
Joined: May 2004
Reputation:
4
sho
Team-XBMC Member
Posts: 4,132
My description may not be the best of the browse, please try it out to see what exactly I mean. (should be pretty apparent once you try)
Posts: 26,215
Joined: Oct 2003
Reputation:
187
Yes, agreed that the playlist selection is not obvious. You have to go in and out for the OK button to highlight - probably something to do with having files acting as folders (the playlists).
I think it'll be better to just retrieve the folder list and display it using the select dialog as is done for everything else. Gives consistency all around that way.
Cheers,
Jonathan