• 1
  • 13
  • 14
  • 15
  • 16
  • 17(current)
[RELEASE] TED Talks (Video) Plugin
> The fixes have been available on this forum for eight years

Recent (not original) developer here. Er what, I'll admit I haven't updated it recently, but 8 years? ROFL!

Is there still interest in getting these updates into the Kodi plugins repository? If someone more active is interested in taking over this responsibility, then that would probably be best for the plugin. I'm not active with Kodi and it takes me a while to get my head back into the game.
If no-one is willing then I might have time this weekend to look into incorporating the patch.

@kevwag: Thanks for publishing a fix version. Can you explain what happened between 5.0.0 and 5.0.3, are there other versions available - the repo-plugins version still seems to be 5.0.0 (https://github.com/xbmc/repo-plugins/blo.../addon.xml)?

Note: it would be helpful if people actually forked the original repo and applied their changes in a commit to that, so that I can easily review what has been done, and pull to the original repo.
Reply
Thank you @moreginger for your work on this add-on.  I am not the person to maintain this add-on.

All my Raspberry Pi 2/3/3B+'s run with older LibreELEC 9.2.x and Kodi 18.x because it performs better for me (no stuttering) for interlaced and other content.  Hence my focus is there, and not on mainstream Kodi.  Note that I do not seek credit for any patches.  I only post these in case they might help others.
Reply
(2022-05-14, 10:45)moreginger Wrote: > @kevwag: Thanks for publishing a fix version. Can you explain what happened between 5.0.0 and 5.0.3, are there other versions available - the repo-plugins version still seems to be 5.0.0 (https://github.com/xbmc/repo-plugins/blo.../addon.xml)?

Note: it would be helpful if people actually forked the original repo and applied their changes in a commit to that, so that I can easily review what has been done, and pull to the original repo.

I incremented the version numbers every time I made significant changes, more for my own benefit than anything else. I'm fairly new to all this and haven't done any serious coding for a couple of decades so the whole GitHub thing is a bit of a learning curve for me at the moment. The "missing" versions were failed attempts at a fully working version:

I DID initially fork your version, to which I then added the four fixed files and committed them back to GitHub. but when I tried to test it in Kodi, the install failed due to dependency on Python 2.x so it appeared that the version on your GitHub repo is not the same as the version in the Kodi Repo. Anyway, that was v5.0.1.

I still haven't worked out how the whole pull-request thing works and how to collaborate with others so I deleted the forked copy and created my own version.

After another failure - v5.0.2 (I forget what went wrong that time), I finally got it working on my third attempt - v5.0.3.
I realise that's not technically how the version numbers are supposed to work as I never actually published v5.0.1 and v5.0.2 publicly but as I was installing it clean and not updating from the broken version, I didn't think that would matter too much (I was originally just intending to create an installable package for my own use, in case I need to reinstall at any point, I then decided to make it available for others who may not have the confidence to go poking around in .py files)

If you want me to delete mine and fork it so you can pull the fixed version, I'm more than happy to do so, I'll just need a little guidance as I don't want to mess anything up along the way.

I moved the addon to a new repo today, under an organisation profile (Kevwag-Kodi-Addons) as it was originally on my personal GitHub page (I only learned about personal and organisation profiles today, otherwise I would have known to do this in the first place).
The links in my previous post have been updated to reflect this and I will leave the copy on my personal account for now.

I'm going to create another organisation profile to learn about forking / pull requests etc so I can try to do this whole thing properly. What would be the accepted way to go about this? Do I fork from your repo or directly from the Kodi repo? (I'm thinking that last time I forked yours, I may have forked the wrong branch, resulting in the Python 2.x problem)
Reply
(2022-05-14, 10:45)moreginger Wrote: > Note: it would be helpful if people actually forked the original repo and applied their changes in a commit to that, so that I can easily review what has been done, and pull to the original repo.

Ignore most of my previous comment. I worked out the forking / pull request thing.
My previous attempt was unsuccessful as I had edited the wrong branch.
I have now edited the correct branch, increased the version number to 5.0.1 and you have a pull request from Kevwag-Kodi-Forks Smile
I've created a release from the forked version and updated the links I posted previously so that future updates from your page or the Kodi repo will work properly.

Anyone who installed the v5.0.3 that I previously posted, please uninstall it, restart Kodi then install THIS ONE instead.
Reply
No problem @kevwag. I'm working on getting those changes incorporated here: https://github.com/moreginger/xbmc-plugi...ted.talks/ - made some progress but there are still a few issues with testing.

Edit: feature/matrix branch of the above looks good AFAICT, but I haven't tested in kodi due to an issue with html5lib / python 3.10 -  https://forum.kodi.tv/showthread.php?tid=368346
Reply
(2022-05-17, 20:48)moreginger Wrote: No problem @kevwag. I'm working on getting those changes incorporated here: https://github.com/moreginger/xbmc-plugi...ted.talks/ - made some progress but there are still a few issues with testing.

Edit: feature/matrix branch of the above looks good AFAICT, but I haven't tested in kodi due to an issue with html5lib / python 3.10 -  https://forum.kodi.tv/showthread.php?tid=368346
I've been using the matrix version since applying the fix and I've not had any errors or problems thus far.
Reply
(2022-05-17, 20:48)moreginger Wrote: No problem @kevwag. I'm working on getting those changes incorporated here: https://github.com/moreginger/xbmc-plugi...ted.talks/ - made some progress but there are still a few issues with testing.

Edit: feature/matrix branch of the above looks good AFAICT, but I haven't tested in kodi due to an issue with html5lib / python 3.10 -  https://forum.kodi.tv/showthread.php?tid=368346
@moreginger, Any chance of updating the Kodi add-on repository with the updated version? It still has version 5.0.0 that does not work anymore. It would be really great to have the add-on working again.
Reply
@ErikBrown, did you propose https://github.com/moreginger/xbmc-plugi...ks/pull/84?
As I said there, it's time for someone else to pick this project up and run with it. I'm unlikely to get around to organizing a PR to the Kodi repo any time soon.
Reply
(2023-11-13, 20:32)moreginger Wrote: @ErikBrown, did you propose https://github.com/moreginger/xbmc-plugi...ks/pull/84?
As I said there, it's time for someone else to pick this project up and run with it. I'm unlikely to get around to organizing a PR to the Kodi repo any time soon.

@moreginger, no the pull request did not come from me. If I would know how to do that, then I would have directly offered to take care of the complete add-on.

Sorry to read that you are not in a position to update the add-on in the Kodi repository. I am sure that many Kodi users will be very happy if it would work again. So if you do find some time then I hope that you reconsider updating it.
Reply
(2023-11-14, 08:57)ErikBrown Wrote: If I would know how to do that

https://docs.github.com/en/pull-requests...ll-request
 
(2023-11-14, 08:57)ErikBrown Wrote: then I would have directly offered to take care of the complete add-on.

https://docs.github.com/en/get-started/q...ork-a-repo
Reply
  • 1
  • 13
  • 14
  • 15
  • 16
  • 17(current)

Logout Mark Read Team Forum Stats Members Help
[RELEASE] TED Talks (Video) Plugin5