[PATCH] Fixed Settings->Music->Files->Look for thumbs on remote shares

  Thread Rating:
  • 1 Votes - 5 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Post Reply
mbuchoff Offline
Junior Member
Posts: 32
Joined: Jun 2007
Reputation: 0
Post: #1
I had to take quite a few liberties to get this working. Let me know how things should work and I will fudge this patch to make it so.

I had to fix some code that rejects remote thumbnails without looking at this option.

Also, for some reason, the CreateThumbnail function in DllLoader displays a scrambled image for remote files, almost as if it only loaded a little bit of the image. CreateThumbnailFromMemory worked fine for JPEGs only.

For non JPEGs that happened to be named Folder.jpg (the thumbnail naming scheme requires a .jpg extension regardless of the file-type), CreateThumbnailFromMemory did not work right away. When I removed the XBMC code that tries to determine the file-type and replaced it with UNKNOWN so cxImage had the responsibility, everything went fine.

http://trac.xbmc.org/ticket/5290
find quote
jmarshall Offline
Team-XBMC Developer
Posts: 24,523
Joined: Oct 2003
Reputation: 138
Post: #2
Thanks for the patch - I'll comment in the trac ticket.

Always read the XBMC online-manual, FAQ and search the forum before posting.
Do not e-mail XBMC-Team members directly asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting please make sure you read this first.


[Image: badge.gif]
find quote