[PATCH] LaunchPlayer - External Video Player Launcher (to launch third-party players)

We just added twins to our family so my hands are 'full' right now

konfoo Wrote:We just added twins to our family so my hands are 'full' right now

Congratulations!!!
Jester, do you think you could activate the "watched" flag once a file has been fed to the external player?

Edit: "No end-user support and no feature/function requests here please!"
Sorry konfoo and Jester, didn't fully realize we were on a different section of the forums now... Could we maybe create a support thread in the Windows area?

konfoo Wrote:We just added twins to our family so my hands are 'full' right now

extra hands never hurt

Congrats !!!

my main goal for tonight is to update the patch to work again with the main SVN, then dust off my coding skillz (been 15 years....) and see if I can change the patch to the dev's requirements and hopefully get it in the main SVN, other requests have to come later ....

patch updated to SVN 16962

edit:
however, i'm getting compile errors now...debuggin

A clean version of the patch is up as well now, and I'll commit this version to SVN as soon as it's been verified that an OS X build works (the files needing adding to the project basically).

jmarshall Wrote:A clean version of the patch is up as well now, and I'll commit this version to SVN as soon as it's been verified that an OS X build works (the files needing adding to the project basically).

The patch fails at 2 hunks: (build 16977)

patching file project/VS2003/XBMC_PC.vcproj
Hunk #1 FAILED at 1425.
1 out of 1 hunk FAILED -- saving rejects to file project/VS2003/XBMC_PC.vcproj.rej
(Stripping trailing CRs from patch.)
patching file project/VS2008Express/XBMC.vcproj
Hunk #1 FAILED at 1992.
1 out of 1 hunk FAILED -- saving rejects to file project/VS2008Express/XBMC.vcproj.rej

I applied the missing lines manually, which seems to lead into a doubling in externalplayer.h

After fixing that, compiling works, but while linking, I receive the following error:

collect2: ld returned 1 exit status
"CExternalPlayer::CExternalPlayer(IPlayerCallback&)", referenced from:
CPlayerCoreFactory::CreatePlayer(EPLAYERCORES, IPlayerCallback&) in PlayerCoreFactory.o
ld: symbol(s) not found
collect2: ld returned 1 exit status


If someone could help me with that....

Thanks,

TvT

cleaned up the cleanup (double file entries)

pitty I don't have a mac lying around, I don't understand the input error, the declaration syntax should be the same on win32 or OSX...

@Jester

The Problems with compiling took place with the old patch revision.
With the new one I only get one error left (see my edited Post above)

tvont Wrote:The patch fails at 2 hunks: (build 16977)

patching file project/VS2003/XBMC_PC.vcproj
Hunk #1 FAILED at 1425.
1 out of 1 hunk FAILED -- saving rejects to file project/VS2003/XBMC_PC.vcproj.rej
(Stripping trailing CRs from patch.)
patching file project/VS2008Express/XBMC.vcproj
Hunk #1 FAILED at 1992.
1 out of 1 hunk FAILED -- saving rejects to file project/VS2008Express/XBMC.vcproj.rej

I applied the missing lines manually, which seems to lead into a doubling in externalplayer.h

After fixing that, compiling works, but while linking, I receive the following error:

collect2: ld returned 1 exit status
"CExternalPlayer::CExternalPlayer(IPlayerCallback&)", referenced from:
CPlayerCoreFactory::CreatePlayer(EPLAYERCORES, IPlayerCallback&) in PlayerCoreFactory.o
ld: symbol(s) not found
collect2: ld returned 1 exit status

Thanks,

TvT

anyone know how to setup externalplayer with mpc-hc? i tried last night with build "-Rev16962-jester-externalplayer" but could only get mpc to start in the background