SSA/ASS Subtitles Not Displaying
#1
Is this just effecting me or what?

What happens is.. XBMC skips a few lines of subs (not sure if there's a pattern as i have not checked any of the subs)

I am playing MKV's (anime) and it happens on both linux and windows platforms.

This effects all of my MKV's (i have not tried mp4's or any other container yet).

So.. has anyone else noticed SSA/ASS sub issues with the 2009 SVN builds?
Reply
#2
Definitely had this problem. This patch I wrote works around it for now.

Code:
Index: xbmc/cores/dvdplayer/Codecs/ffmpeg/libavformat/matroskadec.c
===================================================================
--- xbmc/cores/dvdplayer/Codecs/ffmpeg/libavformat/matroskadec.c        (revision 17203)
+++ xbmc/cores/dvdplayer/Codecs/ffmpeg/libavformat/matroskadec.c        (working copy)
@@ -935,6 +935,10 @@
static void matroska_fix_ass_packet(MatroskaDemuxContext *matroska,
                                     AVPacket *pkt, uint64_t display_duration)
{
+#ifdef _XBOX
+    pkt->duration = display_duration;
+    return;
+#endif
     char *line, *layer, *ptr = pkt->data, *end = ptr+pkt->size;
     for (; *ptr!=',' && ptr<end-1; ptr++);
     if (*ptr == ',')
Reply
#3
peenhammer Wrote:Definitely had this problem. This patch I wrote works around it for now.

Code:
Index: xbmc/cores/dvdplayer/Codecs/ffmpeg/libavformat/matroskadec.c
===================================================================
--- xbmc/cores/dvdplayer/Codecs/ffmpeg/libavformat/matroskadec.c        (revision 17203)
+++ xbmc/cores/dvdplayer/Codecs/ffmpeg/libavformat/matroskadec.c        (working copy)
@@ -935,6 +935,10 @@
static void matroska_fix_ass_packet(MatroskaDemuxContext *matroska,
                                     AVPacket *pkt, uint64_t display_duration)
{
+#ifdef _XBOX
+    pkt->duration = display_duration;
+    return;
+#endif
     char *line, *layer, *ptr = pkt->data, *end = ptr+pkt->size;
     for (; *ptr!=',' && ptr<end-1; ptr++);
     if (*ptr == ',')


Thank you peenhammer, i will try this patch out when i have the time to build from source.
Reply

Logout Mark Read Team Forum Stats Members Help
SSA/ASS Subtitles Not Displaying0