[xnappo]

Yes, it does show 1080i, but as far as i can tell 1080i in xbmc is 1920x1080@30hz, where even though it says 1080i, its at 60Hz which is the 1080p setting.

Yeah, I really don't think it is 1080i. I don't understand why it reports that.

xnappo

[Haggy]

Yeah, I really don't think it is 1080i. I don't understand why it reports that.

xnappo

What does xrandr report? Willing to try out 18670 just for motd2k's patch acceptance sake.

[xnappo]

What does xrandr report? Willing to try out 18670 just for motd2k's patch acceptance sake.

Running an xterm using launcher, then running 'xrandr -q' I get a '*' next to '1920x1080 60hz'. I assume this means that is the current mode. 1080i is also on the list at 30hz with no '*'.

xnappo

[EDIT] running with --verbose, I can confirm the mode is 1920x1080 60Hz non-interlaced.

[Haggy]

Exactly...

[shassino]

Sry for upping thread, i only wanted to know if the safe fullscreen patch is present in Linuxport (VDPAU and Linuxport r merged now right?) rev 18900.

@motd2k: If not, plz can u attach a patch file? And ty for ur work on vdpau.

[Haggy]

Nope, not merged into linuxport. If you checkout -r18670 for example you can find the patch though it might be easier if motd2k supplies a diff of the necessary files.

[philter]

I've been following this thread and the vdpau thread, but must have missed the "patch" discussion. Has the issue in the first post of this thread been fixed with a patch? Which thread can I find the patch in?

[shassino]

U can find the patch in vdpau since rev 18670, i'm trying rigth now to build linuxport svn (don't rember revs 18900~) with the patch.

I'll post the diff file if i got success

[xnappo]

U can find the patch in vdpau since rev 18670, i'm trying rigth now to build linuxport svn (don't rember revs 18900~) with the patch.

I'll post the diff file if i got success

Thanks - would really appreciate that. I really want the MKV aspect ratio fix.

xnappo

[shassino]

I got success, i have now linuxport svn 19150 with safe fullscreen patch, i'm making now the diff file. I'll post soon.

[shassino]

This is the diff file

Code:

diff -r -u xbmc/XBMC/guilib/GUIWindowManager.cpp xbmc_sf/XBMC/guilib/GUIWindowManager.cpp
--- xbmc/XBMC/guilib/GUIWindowManager.cpp    2009-04-02 12:41:37.000000000 +0200
+++ xbmc_sf/XBMC/guilib/GUIWindowManager.cpp    2009-04-02 11:39:59.000000000 +0200
@@ -220,6 +220,9 @@

void CGUIWindowManager::PreviousWindow()
{
+  BOOL safeFull = false;

+  if (g_guiSettings.GetBool("videoscreen.safefull"))

+    safeFull = true;
   // deactivate any window
   CLog::Log(LOGDEBUG,"CGUIWindowManager::PreviousWindow: Deactivate");
   DWORD currentWindow = GetActiveWindow();
@@ -270,7 +273,7 @@
   HideOverlay(pNewWindow->GetOverlayState());

   // deinitialize our window
-  g_audioManager.PlayWindowSound(pCurrentWindow->GetID(), SOUND_DEINIT);
+  if (!safeFull) g_audioManager.PlayWindowSound(pCurrentWindow->GetID(), SOUND_DEINIT);
   CGUIMessage msg(GUI_MSG_WINDOW_DEINIT, 0, 0);
   pCurrentWindow->OnMessage(msg);

@@ -282,10 +285,10 @@

   // ok, initialize the new window
   CLog::Log(LOGDEBUG,"CGUIWindowManager::PreviousWindow: Activate new");
-  g_audioManager.PlayWindowSound(pNewWindow->GetID(), SOUND_INIT);
+  if (!safeFull) g_audioManager.PlayWindowSound(pNewWindow->GetID(), SOUND_INIT);
   CGUIMessage msg2(GUI_MSG_WINDOW_INIT, 0, 0, WINDOW_INVALID, GetActiveWindow());
   pNewWindow->OnMessage(msg2);
-
+  if (safeFull) g_graphicsContext.SetFullScreenRoot(true);
   g_infoManager.SetPreviousWindow(WINDOW_INVALID);
   return;
}

diff -r -u xbmc/XBMC/language/English/strings.xml xbmc_sf/XBMC/language/English/strings.xml
--- xbmc/XBMC/language/English/strings.xml    2009-04-02 12:34:29.000000000 +0200
+++ xbmc_sf/XBMC/language/English/strings.xml    2009-04-02 11:16:14.000000000 +0200
@@ -993,6 +993,8 @@
   <string id="13119">Sinc</string>

   <string id="13120">Strict Pixmap-Texture Binding (requires restart)</string>
+
+  <string id="13121">Safe fullscreen mode</string>
  
   <string id="13130">Display blanking</string>
   <string id="13131">Disabled</string>

diff -r -u xbmc/XBMC/xbmc/Application.cpp xbmc_sf/XBMC/xbmc/Application.cpp
--- xbmc/XBMC/xbmc/Application.cpp    2009-04-02 12:40:34.000000000 +0200
+++ xbmc_sf/XBMC/xbmc/Application.cpp    2009-04-02 11:20:12.000000000 +0200
@@ -834,6 +834,7 @@
#endif

   // set GUI res and force the clear of the screen
+  if (g_guiSettings.GetBool("videoscreen.safefull"))
    g_guiSettings.m_LookAndFeelResolution = AUTORES;
   g_graphicsContext.SetVideoResolution(g_guiSettings.m_LookAndFeelResolution, TRUE, true);

   // initialize our charset converter
@@ -906,6 +907,8 @@
   time(&seconds);
   srand((unsigned int)seconds);

+  if (g_guiSettings.GetBool("videoscreen.safefull"))

+    g_graphicsContext.ToggleFullScreenRoot();
   return CXBApplicationEx::Create(hWnd);
}

diff -r -u xbmc/XBMC/xbmc/GUISettings.cpp xbmc_sf/XBMC/xbmc/GUISettings.cpp
--- xbmc/XBMC/xbmc/GUISettings.cpp    2009-04-02 12:40:34.000000000 +0200
+++ xbmc_sf/XBMC/xbmc/GUISettings.cpp    2009-04-02 11:22:37.000000000 +0200
@@ -633,6 +633,7 @@
   AddString(3, "videoscreen.guicalibration",214,"", BUTTON_CONTROL_STANDARD);
   AddString(4, "videoscreen.testpattern",226,"", BUTTON_CONTROL_STANDARD);
   AddInt(6, "videoscreen.vsync", 13105, DEFAULT_VSYNC, VSYNC_DISABLED, 1, VSYNC_DRIVER, SPIN_CONTROL_TEXT);
+  AddBool(7, "videoscreen.safefull", 13121, false);

   AddCategory(7, "filelists", 14018);
   AddBool(1, "filelists.hideparentdiritems", 13306, false);

[xnappo]

This is the diff file

Thanks a lot. My patch-fu is weak though - mind sharing the command line to patch?

Thanks
xnappo

[fasteddy]

[Edit: Removed instructions. Given that I'm no expert on patch and diff, I don't want to send you down the wrong path.]

[shassino]

open a terminal
move just outside xbmc src folder

patch -p0 < diff_file

u should get:

shm@shm-desktop:/media/htpc$ patch -p0 < diff
patching file xbmc/XBMC/guilib/GUIWindowManager.cpp
patching file xbmc/XBMC/language/English/strings.xml
patching file xbmc/XBMC/xbmc/Application.cpp
patching file xbmc/XBMC/xbmc/GUISettings.cpp

[AllanMar]

So how is everyone making out with this now? Ive just been using the old svn before the patch was removed and its been working quite well. With the exception of the dark knight, for whatever reason.

There is some probs with regards to the library and such in this old version though, so I want to upgrade to the latest linux port. Is this working for anyone? If not I guess ill try the patch posted above.

I have been reading the the VDPAU thread and there seems like there may have been some progress with regards to this prob, any info?