little imdb scraper change

Schenk2302 · 2009-05-09 00:01

hey folks,

if a movie has votes without comma, the whole rating is not shown until you change the regexp:

from:

Code:

<RegExp input="$$1" output="&lt;rating&gt;\1&lt;/rating&gt;&lt;votes&gt;\2&lt;/votes&gt;" dest="5+">

    <expression>&lt;b&gt;([0-9.]+)/10&lt;/b&gt;[^&lt;]*&lt;a href=&quot;ratings&quot; class=&quot;tn15more&quot;&gt;[color=red]([0-9,]+)[/color] votes&lt;/a&gt;</expression>

</RegExp>

to:

Code:

&lt;b&gt;([0-9.]+)/10&lt;/b&gt;[^&lt;]*&lt;a href=&quot;ratings&quot; class=&quot;tn15more&quot;&gt;[color=red](.*?)[/color] votes&lt;/a&gt;

Bye

Schenk

**jmarshall** · 2009-05-09 02:20

Do you have an example movie that shows this behaviour?

Cheers,
Jonathan

Schenk2302 · 2009-05-09 11:09

jmarshall Wrote:Do you have an example movie that shows this behaviour?

Cheers,
Jonathan

http://www.imdb.com/title/tt0825745/

**jmarshall** · 2009-05-09 11:31

Thanks. I'm not sure why the original regexp wouldn't work - is it not detecting anything containing a number or a comma?

I'm just a little worried that yours might be a little too generic.

Will talk with our scraper gurus.

Cheers,
Jonathan

**jmarshall** · 2009-05-10 02:15

Hi there,

According to our tests, this movie scrapes just fine from within XBMC. Perhaps you have some other case where there's more than just numbers and commas involved?

Cheers,
Jonathan

jmarshall Team-XBMC Developer Posts: 24,523 Joined: Oct 2003 Reputation: 138	2009-05-09 02:20 Post: #2 Do you have an example movie that shows this behaviour? Cheers, Jonathan Always read the XBMC online-manual, FAQ and search the forum before posting. Do not e-mail XBMC-Team members directly asking for support. Read/follow the forum rules. For troubleshooting and bug reporting please make sure you read this first.
	find quote

Schenk2302 Senior Member Posts: 103 Joined: Feb 2009 Reputation: 4	2009-05-09 11:09 Post: #3 jmarshall Wrote:Do you have an example movie that shows this behaviour? Cheers, Jonathan http://www.imdb.com/title/tt0825745/
	find quote