[RFC] Database Abstraction Proposal - Request for Comments (Devs and DB Admins only!)

I think the posts about it were lost but did someone figure out a way to get the fanart/thumbnails to work properly on a computer that did not build the library to begin with?

I have been wanting this feature for atleast 4 years I am so glad someone finally got this concept worked out. I use a couple central servers and a bunch of frontends. One xbox running xbmc on every tv in every room in the house hardwired together.I run myth, samba shares, and stream emulation. I can do all this using the central servers the only hassle is library upkeep. This eliminates that but it is not merged with the xbox trunk.

I have the tools to do it and I have a little vb experience I had a class for the 2008 version just last year in college. I am more inclined with linux than microsoft and understand patches in regards to the linux kernel more so than working with anything MS but am unsure exactly how to implement such a thing in vb.
I have compiled my own build before but I built it as it was and didn't change anything. I say this so you know I at least have the ability to build it.

Would it not just be code inserted in at certain places?

Where can I find the code and once I have the code where does it need inserted?

Any help would be greatly appreciated.

run088 Wrote:Would it not just be code inserted in at certain places?

you've just summarized all programming right there.

if you have to ask, you haven't done enough research.

I just spotted this feature, and it looks great. So, I've written a "scrapper" (a python script really) that grabs my movie library from my MySQL database (that was created using Movie Collector)

The python script takes the Movie Collector database, and writes it into a new MySQL database created by XBMC.

For the most part, it's working, but I have a few questions:

What are the Cxx fields? I've figured out some of them, but not all. Here's what I've figured out:


I'm having a problem with thumbnails. Here's an example of a thumbnail in the database:


If I look at the movie details and manually set the thumbnail, I actually see the one that I've set, and can select it. How to I make this thumbnail the default automatically?

Thanks for this great new feature!!!

think I've found a bug, running 28256 on windows 7.

Seems to have problems with actor names like Gavan O'Herlihy specifically with the '.

Looks like it is putting a double ' in the query, its putting O\'' where as I think it should put O\'

Get the following in my log

Quote:22:43:37 T:4908 M:2735472640 ERROR: SQL: Undefined MySQL error: Code (1064)
Query: select idActor from actors where strActor like 'Michael O\''Herlihy'
22:43:37 T:4908 M:2735468544 ERROR: CVideoDatabase::AddActor (Michael O\'Herlihy) failed
22:43:38 T:4908 M:2726039552 ERROR: SQL: Undefined MySQL error: Code (1064)
Query: update episode set c00='Trouble Brewing',c01='Two sisters ask the A-Team for help when they are pressured to convert their all-natural soda pop bottling plant into a brewery.',c02='',c03='0.000000',c04='Burt Pearl / Steven L. Sears',c05='1985-05-07',c06='<thumb>http://images.thetvdb.com/banners/episodes/77904/262827.jpg</thumb>',c07='',c08=NULL,c09='',c10='Michael O\''Herlihy',c11='',c12='3',c13='24',c14='',c15='-1',c16='-1',c17='-1'where idEpisode=428
22:43:38 T:4908 M:2725892096 ERROR: CVideoDatabase::SetDetailsForEpisode (smb://MYTHTV-B1/myth/media/tv_shows/3/A-Team/Season 3/A-Team - S03E24 - Trouble Brewing.avi) failed

bmillham Wrote:I just spotted this feature, and it looks great. So, I've written a "scrapper" (a python script really) that grabs my movie library from my MySQL database (that was created using Movie Collector)

The python script takes the Movie Collector database, and writes it into a new MySQL database created by XBMC.

For the most part, it's working, but I have a few questions:

What are the Cxx fields? I've figured out some of them, but not all. Here's what I've figured out:

Code:

C00 - Title
C01 - Plot
C02 - ???
C03 - ???
C04 - ???
C05 - IMDB rating
C06 - Writer(s)
C07 - Year
C08 - Thumbnails
C09 - ???
C10 - ???
C11 - Duration
C12 - ???
C13 - ???
C14 - Genre
C15 - Director
C16 - ???
C17 - ???
C18 - Studio
C19 - ???
C20 - Fanart

The wiki spells these out in the database description section.

bmillham Wrote:How to I make this thumbnail the default automatically?

Good question well asked ... I'm not on top of the thumbnail generation yet, the new schema is eating up my time.

wstewart Wrote:think I've found a bug, running 28256 on windows 7.

Seems to have problems with actor names like Gavan O'Herlihy specifically with the '.

Looks like it is putting a double ' in the query, its putting O\'' where as I think it should put O\'

Get the following in my log

Could you try the patches on #9022. I believe they will solve the issue. Report back on any success or failure.

First of all, thanks for hard work!

I was waiting this features from a lot of time!

I would ask if is there some chance for "porting" this feature also on xbox branch?

If is not possible for some software limits...or just wait.

I hope this is correct place for ask.

Ciao!

edit: i have found answer to my question...sob!

firnsy Wrote:Could you try the patches on #9022. I believe they will solve the issue. Report back on any success or failure.

currently I`m using the pre-built xbmc packages on linux and windows. I might be able to find some time in the next weeks to try out the patch. For the time being, I`ve executed the failed query manually.

Thanks for your great work on getting mysql support into xbmc.

wstewart Wrote:currently I`m using the pre-built xbmc packages on linux and windows. I might be able to find some time in the next weeks to try out the patch. For the time being, I`ve executed the failed query manually.

Thanks for your great work on getting mysql support into xbmc.

Yes the query is broken. So manually entering it will also fail.

The quoted patch adds a vsnprintf() like function for the mysql translations which I will be aiming to push into the mainline in the next few weeks.

It just needs some more airtime from other testers, before I'm happy enough with it.