[RELEASE] CU Lyrics (Script) Addon

  Thread Rating:
  • 1 Votes - 5 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Post Reply
sonic Offline
Member
Posts: 72
Joined: May 2004
Reputation: 0
Post: #21
Hi!

I like your script a lot but I think I have found a little "bug".. If I for example play "Helloween - Livin' ain't no crime" it can´t find any lyrics for me but if I change the song title in the ID3 tag to "Livin aint no crime" the script finds the lyrics right away Smile. So it seems to have some problems if the song name/title has " ' " characters in it.

I have tried several other songs too, and I got the same results.

Thanks for a great script!

/Sonic
(This post was last modified: 2009-11-30 19:22 by sonic.)
find quote
amet Offline
I wave my private parts at your aunties!
Posts: 3,480
Joined: Jul 2009
Reputation: 18
Location: Novi Sad / Dubai
Post: #22
sonic Wrote:Hi!

I like your script a lot but I think I have found a little "bug".. If I for example play "Helloween - Livin' ain't no crime" it can´t find any lyrics for me but if I change the song title in the ID3 tag to "Livin aint no crime" the script finds the lyrics right away Smile. So it seems to have some problems if the song name/title has " ' " characters in it.

I have tried several other songs too, and I got the same results.

Thanks for a great script!

/Sonic

Thanks for the feedback,

I would appreciate if you could post the log and upload the song somewhere so that I can test

Thanks,
Zeljko


Always read the XBMC_Online_Manual,Frequently_Asked_Questions and search the forum before posting.
For troubleshooting and bug reporting use -> Log_file.
find quote
paco Offline
Senior Member
Posts: 234
Joined: Mar 2008
Reputation: 0
Location: Toronto
Post: #23
Amet Wrote:Thanks for the feedback,

I would appreciate if you could post the log and upload the song somewhere so that I can test

Thanks,
Zeljko

Hi Zeljko,

I also ran into the same problem. Your script capitalizes the T after an apostrophe ("Ain't" becomes "Ain'T" which then fails to find any results). See example:

NOTICE: SongAin't Talkin' 'Bout Love
NOTICE: ArtistVan Halen
NOTICE: Title:[Van Halen:Ain'T Talkin' 'Bout Love]
NOTICE: http://lyricwiki.org/index.php?title=Van...ction=edit

Another issue I have noticed is quotes (") within lyrics aren't scraped correctly. See following link:

http://lyricwiki.org/index.php?title=Van...ction=edit

At the end of the song, the line:

(This is home) Somebody said "fair warning"!

Gets scraped as:

(This is home) Somebody said "fair warning"!


Keep up the great work!
find quote
amet Offline
I wave my private parts at your aunties!
Posts: 3,480
Joined: Jul 2009
Reputation: 18
Location: Novi Sad / Dubai
Post: #24
paco Wrote:Another issue I have noticed is quotes (") within lyrics aren't scraped correctly. See following link:

http://lyricwiki.org/index.php?title=Van...ction=edit

At the end of the song, the line:

(This is home) Somebody said "fair warning"!

Gets scraped as:

(This is home) Somebody said "fair warning"!


Keep up the great work!

If you look at the Page source, thats where we get the lyrics from, it shows ""fair warning"".There is an ugly hack to get rid of it in V 0.6.1, first post has download link

I am not entirely sure how to handle the " ' " issue, I'll look at it over the weekend


Thanks for letting me know.

Zeljko


Always read the XBMC_Online_Manual,Frequently_Asked_Questions and search the forum before posting.
For troubleshooting and bug reporting use -> Log_file.
find quote
sonic Offline
Member
Posts: 72
Joined: May 2004
Reputation: 0
Post: #25
Quote:I am not entirely sure how to handle the " ' " issue, I'll look at it over the weekend

Thank you for looking at it, i hope you will find a fix for that.

/Sonic
find quote
willers.nail Offline
Senior Member
Posts: 297
Joined: Apr 2007
Reputation: 0
Location: Ireland
Post: #26
well done on this script works rather well. I'm using this on the xbox and find that some times the lyrics don't appear for the next song when skipping the track back and forward. They appear for split second then the song you just had on come up again which is obviously incorrect.
find quote
amet Offline
I wave my private parts at your aunties!
Posts: 3,480
Joined: Jul 2009
Reputation: 18
Location: Novi Sad / Dubai
Post: #27
willers.nail Wrote:well done on this script works rather well. I'm using this on the xbox and find that some times the lyrics don't appear for the next song when skipping the track back and forward. They appear for split second then the song you just had on come up again which is obviously incorrect.

Thanks for the info, I'll look into it over the weekend


Always read the XBMC_Online_Manual,Frequently_Asked_Questions and search the forum before posting.
For troubleshooting and bug reporting use -> Log_file.
find quote
alanwww1 Offline
Team-XBMC Member
Posts: 1,299
Joined: Nov 2008
Reputation: 31
Location: Hungary
Post: #28
I just want to thank you Amet for keeping alive this plugin. Smile

This plugin is a must for me. Working really great.

Thanks again.

Always read the XBMC online-manual, FAQ and search the forum before posting.
Do not e-mail XBMC-Team members directly asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting please make sure you read this first.
find quote
amet Offline
I wave my private parts at your aunties!
Posts: 3,480
Joined: Jul 2009
Reputation: 18
Location: Novi Sad / Dubai
Post: #29
alanwww1 Wrote:I just want to thank you Amet for keeping alive this plugin. Smile

This plugin is a must for me. Working really great.

Thanks again.

NP Smile, credit to the original authors as well.

I have added the latest version to SVN Repo Installer, any problems please let me know.


Always read the XBMC_Online_Manual,Frequently_Asked_Questions and search the forum before posting.
For troubleshooting and bug reporting use -> Log_file.
find quote
amet Offline
I wave my private parts at your aunties!
Posts: 3,480
Joined: Jul 2009
Reputation: 18
Location: Novi Sad / Dubai
Post: #30
and another new version on SVN Repo InstallerSmile

0.7.0 attempts to fetch lyrics for the next track/song and saves it to file. when track changes, the lyrics (if exist) are shown immediately.

Zeljko


Always read the XBMC_Online_Manual,Frequently_Asked_Questions and search the forum before posting.
For troubleshooting and bug reporting use -> Log_file.
find quote
Post Reply