[RELEASE] CU Lyrics (Script) Addon

Amet Wrote:try version 0.7.1 on SVN repo installer. I would appreciate the feedback as my music library is almost nonexistent.

v 0.7.1 should fix """, "&" and others, as for the ( ' ) issue , the script will not capitalize any artist or song name with ( ' ) in it. the best would probably be to search for it in a title and decapitalize the letter after it.


I will have some more time over the weekend and I should be able to fix it.

Zeljko

Hi Zeljko,

Thanks for the update. Good job on the (') issue. From the quick test I gave the file, most of my problem files worked! Very nice! Even quotes (") in songs were showing up correctly!

This version seems to have trouble when switching songs. Sometimes it refreshes, other times it doesn't. I have to start and stop the script sometimes. No such issue with 0.70. I find that if the next song is available on the HDD, it refreshes. If it has to go to the internet, it doesn't.

Great progress with this script! Keep up the nice work!

paco Wrote:Hi Zeljko,

Thanks for the update. Good job on the (') issue. From the quick test I gave the file, most of my problem files worked! Very nice! Even quotes (") in songs were showing up correctly!

This version seems to have trouble when switching songs. Sometimes it refreshes, other times it doesn't. I have to start and stop the script sometimes. No such issue with 0.70. I find that if the next song is available on the HDD, it refreshes. If it has to go to the internet, it doesn't.

Great progress with this script! Keep up the nice work!

Thanks for letting me know, mind trying 0.7.2 on SVN?

I have to stop doing this at 3AM, always make silly little mistakes.

Zeljko

Amet Wrote:Thanks for letting me know, mind trying 0.7.2 on SVN?

I have to stop doing this at 3AM, always make silly little mistakes.

Zeljko

Wow! Awesome job Zeljko! Now when your script fails it makes me check the lyricwiki. Believe it or not, in a few cases I had a misnamed song and in a few cases they had it wrong (always check original album when in doubt!).

There is still one issue I have found. Artists with an ampersand in the name (see below):

NOTICE: Song: Is This Love
NOTICE: Artist: Bob Marley & The Wailers
NOTICE: Title:[Bob Marley & The Wailers:Is This Love]
NOTICE: http://lyricwiki.org/index.php?title=Bob...ction=edit

It seems that your script sends 2 ampersands when formatting the artist or title.

That small problem aside, your script kicks major butt! Great work!

paco Wrote:Wow! Awesome job Zeljko! Now when your script fails it makes me check the lyricwiki. Believe it or not, in a few cases I had a misnamed song and in a few cases they had it wrong (always check original album when in doubt!).

There is still one issue I have found. Artists with an ampersand in the name (see below):

NOTICE: Song: Is This Love
NOTICE: Artist: Bob Marley & The Wailers
NOTICE: Title:[Bob Marley & The Wailers:Is This Love]
NOTICE: http://lyricwiki.org/index.php?title=Bob...ction=edit

It seems that your script sends 2 ampersands when formatting the artist or title.

That small problem aside, your script kicks major butt! Great work!

Thanks for all the reports, I think its fixed in 0.7.3. Give it a go when you have some time.

Zeljko

Hi Amet,

Still have the problem with internet radio that it doesn't refresh
if I exit the script and go back then it's finding the correct lyric

With this new version a lot of songs are working that didn't work before
Thanks!!!

Amet Wrote:Thanks for all the reports, I think its fixed in 0.7.3. Give it a go when you have some time.

Zeljko

Hello Zeljko, boy are you making it hard to find bugs! This new version is ALMOST perfect. Below is the only songs I've issues with. The funny thing is your script tries to scrape from the proper page but some songs work, yet others come back 'No Lyrics Have Been Found'. Maybe you have some debugging options to see what is causing the script to come back empty.

Work Fine:
NOTICE: Title:[Creedence Clearwater Revival:Fortunate Son]
NOTICE: http://lyricwiki.org/index.php?title=Cre...ction=edit

NOTICE: Title:[Creedence Clearwater Revival: Down On The Corner] (I had to add space between : & D to avoid smiley)
NOTICE: http://lyricwiki.org/index.php?title=Cre...ction=edit

No Lyrics Have Been Found:
NOTICE: Title:[Creedence Clearwater Revival:Hey Tonight]
NOTICE: http://lyricwiki.org/index.php?title=Cre...ction=edit

NOTICE: Title:[Creedence Clearwater Revival:Proud Mary]
NOTICE: http://lyricwiki.org/index.php?title=Cre...ction=edit

Good luck troubleshooting!

mvdaat Wrote:Hi Amet,

Still have the problem with internet radio that it doesn't refresh
if I exit the script and go back then it's finding the correct lyric

With this new version a lot of songs are working that didn't work before
Thanks!!!

Internet radio? wouldnt even know how to test.

post the debug log let me have a look.

Zeljko

internet radio may not trigger the player start event on song change even though the title changes.

so it wouldn't work without a constant thread checking song title (not good)

paco Wrote:Hello Zeljko, boy are you making it hard to find bugs! This new version is ALMOST perfect. Below is the only songs I've issues with. The funny thing is your script tries to scrape from the proper page but some songs work, yet others come back 'No Lyrics Have Been Found'. Maybe you have some debugging options to see what is causing the script to come back empty.

Hopefully we'll get to the point that it just works . Thanks a lot for your help debugging it.

paco Wrote:No Lyrics Have Been Found:
NOTICE: Title:[Creedence Clearwater Revival:Hey Tonight]
NOTICE: http://lyricwiki.org/index.php?title=Cre...ction=edit

NOTICE: Title:[Creedence Clearwater Revival:Proud Mary]
NOTICE: http://lyricwiki.org/index.php?title=Cre...ction=edit

Good luck troubleshooting!

hehe, the problem is actually on the LyricWiki page.

I have fixed the Creedence Clearwater Revival:Hey Tonight and left Creedence Clearwater Revival:Proud Mary for you to see.

the lyrics need to be wrapped in "<lyrics>" tag, whoever edited the Proud Marry and Hey Tonight songs has put "<lyric>" as a tag and thats why we are not seeing it.

If a lot of those start popping up I will add the check for "<lyric>" tag.

Zeljko

Amet Wrote:hehe, the problem is actually on the LyricWiki page.

I have fixed the Creedence Clearwater Revival:Hey Tonight and left Creedence Clearwater Revival:Proud Mary for you to see.

the lyrics need to be wrapped in "<lyrics>" tag, whoever edited the Proud Marry and Hey Tonight songs has put "<lyric>" as a tag and thats why we are not seeing it.

If a lot of those start popping up I will add the check for "<lyric>" tag.

Zeljko

Good find. I don't know how I missed that when comparing the working songs with the failed songs. I ran into a few other problem songs last night and after reading your post I went back to check them. Yup, the same issue (<lyric> instead of <lyrics>). Here is a sample:

http://lyrics.wikia.com/index.php?title=...ction=edit

http://lyrics.wikia.com/index.php?title=...ction=edit

I could just edit the songs on lyricwiki, but there may be many more we're not aware of. If it's possible, it might be better to add a check for <lyric> as well (maybe if <lyrics> returns 0 results?).

Another suggestion I wanted to make was the handling of Instrumentals. Rather than have the script search every time one is played and return 'No Lyrics Have Been Found', I think it would be better to save the text file for the song with words "Instrumental" for lyrics. That would prevent a needless search (and subsequent fail) when part of a playlist. I notice most Instrumentals have the following tag inside the lyrics {{Instrumental}}.