Adding new password dialog to protect share access

is it possible to add top level entries then?

in other words, if i add a "games-mature" to the front page, it sounds like i may be able to lock that...if it is possible to add to the top-level menu (i.e. programs, games-mature, music....)

i know there are entries in the xml file for these, i just don't understand the dialogs they are being assinged to to add my own...

thanks!!

@scampa123

no, you cant lock anything but a share. once the password protection works for my programs bookmarks, you can setup a bookmark for it, example:

Quote:<myprograms>
<bookmark>
<name>games</name>
<path>f:\games</name>
</bookmark>
<bookmark>
<name>mature games</name>
<path>f:\mature games</name>
<lockmode>1</lockmode>
<lockcode>12345678</lockcode>
</bookmark>
</myprograms>

again, this currently does not work for my programs but does work for the other sections. slacker is working on it though.

@slacker

the problem you may be having with my programs could be related to the fact that everything is automaticly added to the database. i'm thinking you probably need to do the check inside the "// launch xbe" section of onclick using the "szpath" parameter.

take a look at my patch for activatewindow, you can copy some of that code. (look in guiwindowmymusicsongs.cpp)

http://sourceforge.net/tracker....=581840

in short, i had to match up a full path to the appropriate bookmark, and then create a temporary pitem to pass to havebookmarkpermissions before allowing the window to open up to that full path.

slacker, you been busy! this is all great news. pm me when you get the developers to add the code to cvs so i can do my part but to be honest, the samba password entry code is really very small. i wish i could do more.

kraqh3d ,

thank you...that is exactly what i want to do...

i will keep looking for this fix in future releases...

thanks again!

submitted sf patch 1097753. here is the readme.txt:
patch merge instructions:
1) download the 6-jan-2005 cvs to a folder
2) download the patch
3) unzip the patch and copy the files/folders in it onto the cvs, overwriting
existing files.
4) open the xbmc solution in vs, then make sure that xbmc is set as the
startup project in solution explorer (it should be in bold print)
5) remove the following new files from the xbmc project in solution explorer:
guidialogpasswordgamepad.cpp and guidialogpasswordnumeric.cpp -> located
in /xbmc/source files/gui dialog
guidialogpasswordgamepad.h and guidialogpasswordnumeric.h -> located in
/xbmc/header files
5) add the following files to the xbmc project in solution explorer:
guidialoggamepad.cpp and guidialognumeric.cpp -> add to
/xbmc/source files/gui dialog
guipassword.cpp -> add to /xbmc/source files/utils
guidialoggamepad.h, guidialognumeric.h, guipassword.h -> add to
/xbmc/header files
6) build the solution, make sure there are no errors (warnings are ok)
7) close vs. run build.bat.
4) delete the following files, they are no longer needed:
xbmc\xbmc\guidialogpassword*.*
8) you're done, the patched cvs is built.


notes:
- rewrote most of the masterlock/share lock code so that it is cleaner
and more reusable elsewhere in xbmc
- added ability to en/disable masterlock and configure it as a
numeric/gamepad/fulltext lock
- added logic which automatically overrides share locks if masterlock
is disabled
- changed default xml config to no security (masterlock disabled)
- added ability to reactivate a share lock after it's already been unlocked
- added ui prompt to remember masterlock until xbmc is rebooted, and
optionally override locally stored lock passwords
- changed numeric lock dialog to put focus on enter button by default
- changed numeric lock remote input so that select == a instead of start
- renamed guidialogpasswordnumeric and guidialogpasswordgamepad code to the
same names without "password" since they are now reusable for other purposes
- added new functions to the cguidialogyesno and cguidialogok to make it
easier to show these dialogs in other code
- edited build.bat to allow it to work on machines with non-standard vs 2003
install paths. you may want to verify the env var used exists on a bunch
of different user installations before accepting the change.


note to xbmc devs merging this into cvs:
i did not convert any dos carriage returns my editing apps may have
inserted to the unix format. i have tools that can do this, but
i'm too paranoid to use them right now for fear that they'll
munge everything up.
i did moderate to heavy testing on this patch. there are some bugs
that i did not fix which are listed below:

1) add/update/delete bookmarks in my videos using the context menu fails
to actually save them to the xml file. the reason is because the strtype
being used is "videos" when the xml specifies "video". i thought i fixed
this once already, but it seems to now be wrong in several different
places that i'm pretty sure i never touched.
2) headings are no longer showing up in gamepad and keyboard dialogs. this
bug also currently is in the cvs. it used to work awhile ago.
3) guikeyboard.cpp has some override cstdstringw functions which use cstdstring
functions, thereby losing the wide data. they need to be reversed so the
cstdstringw is the main function and the cstdstring is the override.
4) the new ui functions i added to some of the guidialog* classes cannot show a
string as a heading or line if it begins with a number, even if the rest of
the string contains text. this is because _wtoi returns the number and drops
the rest of the string, instead of returning -1 as i expected it to do.

doh, i just realized that i need to go back and fix a lot of the usage comments for the new functions i wrote. most of them have either incorrect or missing usage comments.

slacker,
you forgot to add the header for xkutils.h to guipassword.cpp. this only hits when compiling a release version which i did because i was looking to see if the linker error i was getting would go away under a release build. it didn't.

i don't know why but i was missing some lib files in the download i did today from cvs. i kept getting "cannot open file" to the path xbmc/lib/liblame/liblame.lib. i just copied the liblame directory from a december download i had. also, the liboggvorbis lib directory was missing.

thanks btemp, good catch.  i've just fixed the xkutils bug, added usage comments for the new functions i wrote, and thanks to a tip from kraqh3d i also fixed the bug #4 ("can't show a string that begins with a number") i listed in the previous patch readme.txt.  i also picked up the cvs changes all the way up to this point:
 - 08-01-2005 changed: minor guiimage & xprfont performance tweaks
posting to sf now...

i'm not sure what's the deal with your missing directories.  personally, i always d/l the cvs to a folder, make a copy of that folder, and work strictly with the copy.

is there a certain version of the xdk that the xbmc is meant to be built with?

5788 and above should be fine.