Over the last few days, in an effort to learn XBMC code, I have been stepping through and reading the scraper code. Its an impressive framework, but also very complex if you're not familiar with.
Would the dev's accept a patch with comments only for the scraper? I think this would benefit anyone looking at the code in future.
I would propose adding doxygen comments to:
It would be function signature commenting only, I wouldn't touch the code or add any inline commenting (to make it easier to accept the patch - I could add this later if needed).
I don't want to waste my time, so thought I would check first.
Would a comment only patch for the scraper be accepted?
Joined: Jan 2007
Location: Dubai, United Arab Emirates
2010-05-04 17:09 Post: #1
Joined: Oct 2003
2010-05-04 23:27 Post: #2
Definitely - comment only patches are extremely welcome. I'm more than happy to spend time reviewing it, so cc me on the patch and I'll get it in. Feel free to include inline comments as well where you think they're warranted.
Always read the XBMC online-manual, FAQ and search the forum before posting.
Do not e-mail XBMC-Team members directly asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting please make sure you read this first.