ATTENTION! Changes for skin compatibility post XBMC DHARMA

**jmarshall** · 2010-06-27 11:05

xbmc.python.pluginsource

Cheers,
Jonathan

Hitcher · 2010-06-27 11:15

Cheers.

snowdrift · 2010-07-21 22:01

I'm currently in the process of porting my homebrew version of the good ol' Aeon skin to the new framework. My current svn is pre-Camelot so there is *a lot* to do! Rofl

All going reasonably well so far and got it mostly working except that under my current svn of r31938 I notice that in MusicVisualisation when I bring up the MusicOSD and try and change the visualization type, all the usual suspects like ProjectM, Waveform, OpenGL Spectrum are there but the "None" option seems to be missing? I used to use this to display the album fanart in the background instead of one of the visualizations.

Have I missed something, i.e. do I need to write a new plugin? Or is it just not possible to do this anymore? Thanks.

**Jezz_X** · 2010-07-21 23:03

No you right its a bug when called from that window (works in settings)

Hitcher · 2010-07-21 23:03

It's set to 'None' using the normal Settings > Audio > Visualisation route.

snowdrift · 2010-07-21 23:09

Hitcher Wrote:It's set to 'None' using the normal Settings > Audio > Visualisation route.

Yeah, I tried that too. No visualisation as expected, but the background was just blank. Probably me then...I'll add that to the list of things to sort. Cheers Jezz_X and Hitcher.

EDIT: Trying not to hijack this thread...but my code in MusicVisualistation.xml looks fine. The <texture> path looks to be OK with cdartpath defined. Have any of the controls or boolean conditions been deprecated and I've missed it?

EDIT2: Figured it out. It looks like Visualisation.Enabled is returning TRUE even if the visualisation is set to None from the music settings. Bug maybe? Looks like I can work around it by doing IsEmpty(Visualisation.Name) instead

Code:

<control type="largeimage">

        <include>FullscreenDimensions</include>

<texture>$INFO[Skin.String(cdartpath)]/$INFO[MusicPlayer.Artist]/$INFO[MusicPlayer.Album]/fanart.jpg</texture>

          <fadetime>400</fadetime>

          <include>Animation_FanartFade</include>

          <visible>!Visualisation.Enabled + Player.HasAudio</visible>

    </control>

sialivi · 2012-01-06 09:43

The wiki briefly mentions the following change that doesn't have it's own bulletpoint in the first post:

Quote:ActivateWindow(VideoLibrary,MovieTitles) (dharma)
ActivateWindow(Videos,MovieTitles) (eden)

...and the table of names on the wikipage hasn't been updated. Which ones have been renamed and to what?

Hitcher · 2012-01-06 17:22

You want this thread for Eden changes.

sialivi · 2012-01-06 19:58

Thanks, was tricked by the big "ATTENTION!" in the thread title Smile

jmarshall Team-XBMC Developer Posts: 24,523 Joined: Oct 2003 Reputation: 138	2010-06-27 11:05 Post: #51 xbmc.python.pluginsource Cheers, Jonathan Always read the XBMC online-manual, FAQ and search the forum before posting. Do not e-mail XBMC-Team members directly asking for support. Read/follow the forum rules. For troubleshooting and bug reporting please make sure you read this first.
	find quote

Hitcher Skilled Skinner Posts: 9,933 Joined: Aug 2007 Reputation: 67 Location: Eastleigh, UK	2010-06-27 11:15 Post: #52 Cheers.
	find quote

Jezz_X Team-XBMC Skinner Posts: 5,264 Joined: Jun 2006 Reputation: 55 Location: Earth	2010-07-21 23:03 Post: #54 No you right its a bug when called from that window (works in settings) Skins I have done.... And others in the past... Want to know what I'm working on currently? Check me out on Google+
	find quote

Hitcher Skilled Skinner Posts: 9,933 Joined: Aug 2007 Reputation: 67 Location: Eastleigh, UK	2010-07-21 23:03 Post: #55 It's set to 'None' using the normal Settings > Audio > Visualisation route.
	find quote

sialivi Posting Freak Posts: 946 Joined: Dec 2008 Reputation: 7 Location: Sweden	2012-01-06 09:43 Post: #57 The wiki briefly mentions the following change that doesn't have it's own bulletpoint in the first post: Quote:ActivateWindow(VideoLibrary,MovieTitles) (dharma) ActivateWindow(Videos,MovieTitles) (eden) ...and the table of names on the wikipage hasn't been updated. Which ones have been renamed and to what?
	find quote

Hitcher Skilled Skinner Posts: 9,933 Joined: Aug 2007 Reputation: 67 Location: Eastleigh, UK	2012-01-06 17:22 Post: #58 You want this thread for Eden changes.
	find quote

sialivi Posting Freak Posts: 946 Joined: Dec 2008 Reputation: 7 Location: Sweden	2012-01-06 19:58 Post: #59 Thanks, was tricked by the big "ATTENTION!" in the thread title
	find quote