Posts: 3,660
Joined: Feb 2008
Reputation:
93
Jeroen
Team-Kodi Member
Posts: 3,660
I'm running into a bit of trouble skinning because of a difference between the imdb and moviedb scrapers regarding movie duration.
The moviedb scraper outputs the duration in numbers only, so I feel I have to give the duration info label a suffix like "minutes" or "min"
No biggie in itself, except that the imdb scraper output has "min" already attached. And of course often times extra information for different countries.
So I can't attach "min" after that because, that would look silly. There is no way I can make the infolabel conditional based on the selected scraper.
So, any chance the moviedb scraper's output can be adjusted so "min" is appended to the duration output?
Posts: 4,146
Joined: Jan 2008
Reputation:
40
Yeah, ideally we should just scrape the numeric duration and provide the unit as a localized string. Mind creating a new feature request ticket for this?
Always read the
online manual (wiki),
FAQ (wiki) and search the forum before posting.
Do not PM or e-mail Team-Kodi members directly asking for support. Read/follow the
forum rules (wiki).
Please read the pages on
troubleshooting (wiki) and
bug reporting (wiki) before reporting issues.
Posts: 26,215
Joined: Oct 2003
Reputation:
187
IIRC there's some code in StringUtils to take care of the "min" thing that imdb adds. It should ideally be normalized in the database, however.
Cheers,
Jonathan
Posts: 4,146
Joined: Jan 2008
Reputation:
40
FYI, r30825 takes care of that one. I've also updated most of the scrapers to reflect recent changes.
Always read the
online manual (wiki),
FAQ (wiki) and search the forum before posting.
Do not PM or e-mail Team-Kodi members directly asking for support. Read/follow the
forum rules (wiki).
Please read the pages on
troubleshooting (wiki) and
bug reporting (wiki) before reporting issues.
Posts: 4,146
Joined: Jan 2008
Reputation:
40
You're welcome. Note, there's still an issue with stacked files that i am working on atm.
Always read the
online manual (wiki),
FAQ (wiki) and search the forum before posting.
Do not PM or e-mail Team-Kodi members directly asking for support. Read/follow the
forum rules (wiki).
Please read the pages on
troubleshooting (wiki) and
bug reporting (wiki) before reporting issues.
Posts: 3,379
Joined: Feb 2009
Reputation:
15
mcborzu
Skilled Skinner
Posts: 3,379
Just wanted to 2x check...
You guys are also stripping the extra info out of .nfo's? I was wondering how we(skinners) would deal with people who use Ember...
On 30851 I just noticed all my runtimes which were scrapped using Ember used to show:
1 hrs and 44 mins
now show:
107
So no matter what people use, internal or external scrappers, we will now just get the duration outputted in minutes only?
Check out Night - A Skin For XBMC
Posts: 26,215
Joined: Oct 2003
Reputation:
187
The skinner can already do that.
Posts: 3,379
Joined: Feb 2009
Reputation:
15
mcborzu
Skilled Skinner
Posts: 3,379
The way I interpreted JM's response was there is a way like so:
ListItem.duration returns 93
and
ListItem.durationhrmin returns 1 hr and 33 min
Sort of like there is ListItem.Cast and ListItem.CastandRole
Check out Night - A Skin For XBMC
Posts: 26,215
Joined: Oct 2003
Reputation:
187
ListItem.Duration(HH:MM) doesn't work?
