"NfoScrape" scraper function

  Thread Rating:
  • 0 Votes - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Post Reply
dbrobins Offline
Member
Posts: 73
Joined: Dec 2009
Reputation: 0
Location: Redmond, WA
Question  "NfoScrape" scraper function
Post: #1
While the "NfoUrl" scraper function is documented a few places on the wiki (Scrapers, HOW-TO write media info scrapers, and Import-Export Library), I was looking at the code (still thinking of building a Python scraper interface) and found invocation of a "NfoScrape" function (NfoFile.cpp, CNfoFile::Scrape) which I don't see documented anywhere. Is this a vestigial function that's not used any more, or is it an interface that should be documented? My reason for asking is to determine whether I would need to support it for Python scrapers, or if it can be removed entirely.
find quote
spiff Offline
Retired Developer
Posts: 12,386
Joined: Nov 2003
Post: #2
it can be removed, it was a failed attempt at scraping info from nfo files that ship with music video scene releases.
find quote
spiff Offline
Retired Developer
Posts: 12,386
Joined: Nov 2003
Post: #3
but in any case, you should really not design your api to only handle the currently used functions. the scraper functions are general beasts. the particular uses (movie, tvshow, musicvideo, album, artist) are semantics put on top of the general parser.
find quote
dbrobins Offline
Member
Posts: 73
Joined: Dec 2009
Reputation: 0
Location: Redmond, WA
Post: #4
spiff Wrote:but in any case, you should really not design your api to only handle the currently used functions. the scraper functions are general beasts. the particular uses (movie, tvshow, musicvideo, album, artist) are semantics put on top of the general parser.

I don't intend to, although I think a little encapsulation is in order - e.g., exposing scraper.GetParser() seems out of line when the scraper isn't an XML parser.
find quote
dbrobins Offline
Member
Posts: 73
Joined: Dec 2009
Reputation: 0
Location: Redmond, WA
Post: #5
Ditto with the "FileNameScrape" function (called from utils/IMDB.cpp, CIMDB::ScrapeFilename, checked for in CIMDB::InternalFindMovie)? Nothing in addons/ appears to be using it and I can't find any documentation for it.
find quote
spiff Offline
Retired Developer
Posts: 12,386
Joined: Nov 2003
Post: #6
as the name says, it's used for scraping filenames. useful as a last resort with music videos.
find quote