[outleradam]

Comskip based upon frame number are being handled improperly. Every single file is not skipping frames properly. MythTV handles the comskip information just fine, but XBMC is not doing it properly.

Debug Log: http://pastebin.com/5NGxWuLW

The comskip files are generated using framenumber as per this wiki article:http://wiki.xbmc.org/index.php?title=EDL_(commercial_skipping)_and_SceneMarker_support#Comskip


I can verify that the file is skipping on-time as per the debug log..

Code:

11:24:21 T:2884225904 M:1532760064   DEBUG: ReadEditDecisionLists - Checking for edit decision lists (EDL) on local drive or remote share for: /home/mythtv/Videos/Episodes/The Fairly OddParents/Season 7/The Fairly OddParents S07E09 (Cheese And Crockers).mpg
11:24:21 T:2884225904 M:1532760064 WARNING: ReadComskip - Frame rate not in Comskip file. Using detected frames per second: 59.940
11:24:21 T:2884225904 M:1532760064   DEBUG: AddCut - Pushing new cut to back [00:00:00.000 - 00:00:24.491], 3
11:24:21 T:2884225904 M:1532760064   DEBUG: AddCut - Pushing new cut to back [00:05:03.036 - 00:06:53.996], 3
11:24:21 T:2884225904 M:1532760064   DEBUG: AddCut - Pushing new cut to back [00:11:55.014 - 00:13:09.421], 3
11:24:21 T:2884225904 M:1532760064   DEBUG: ReadComskip - Read 3 commercial breaks from Comskip file: /home/mythtv/Videos/Episodes/The Fairly OddParents/Season 7/The Fairly OddParents S07E09 (Cheese And Crockers).txt
11:24:21 T:2884225904 M:1532760064   DEBUG: AddSceneMarker - Inserting new scene marker: 00:00:24.491
11:24:21 T:2884225904 M:1532760064   DEBUG: AddSceneMarker - Inserting new scene marker: 00:05:03.036
11:24:21 T:2884225904 M:1532760064   DEBUG: AddSceneMarker - Inserting new scene marker: 00:06:53.996
11:24:21 T:2884225904 M:1532760064   DEBUG: AddSceneMarker - Inserting new scene marker: 00:11:55.014

FFMPEG reports the framerate as 59.94

However, mythtv skips by using this framenumber information just fine and xbmc does not.

[outleradam]

Bump. Anything I can do about this?

[GregoryK]

Similar problem here.

Video stops playing and goes back to menu when it hits the first commercial skip. File plays back fine in mythfrontend.

Ticket 9946 is the only related trac ticket I could find, but deals with manual cutlists.

[outleradam]

Bump. I've stopped using comskip files all together. It's not worth the hassle of having to skip back 1 minute every time XBMC decides it's commercial time. Is there a remedy?

[outleradam]

It seems that XBMC is detecting the wrong frames in the video. XBMC adjusts the frame number in the debug log quite a few times. Are cutlists adjusted when XBMC adjusts?

[Nick8888]

FWIW comskips edls are working fine here ( svn from a week or two ago).

[outleradam]

comskip v1 or v2 EDL? I'm using V1.

[Harry Muscle]

Would you happen to know the correct frame rate information for the file? Is it interlaced? Could you copy and paste the comskip file here that generated the above debug log?

I have a feeling XBMC is detecting the wrong frame rate information for the video file cause it's probably interlaced. The code to fix this is actually already in XBMC, but you'd have to run the latest SVN version (like Dharma Beta 2). If you're able to give that a try and report back that would be good. If it's still an issue in Dharma Beta 2 I'll try to take a look at the code and see what's going on.

Thanks,
Harry

[dteirney]

@outleradam, this problem could be related to http://trac.xbmc.org/ticket/10234

I've been meaning to commit that for ages but haven't had any spare weekend hours to get around to it.

I can't port that change back into the Dharma release as it could have unwanted flow on effects. However, if you are running with trunk can you try it out and let me know if that helps.

[dteirney]

Would you happen to know the correct frame rate information for the file? Is it interlaced? Could you copy and paste the comskip file here that generated the above debug log?

I have a feeling XBMC is detecting the wrong frame rate information for the video file cause it's probably interlaced. The code to fix this is actually already in XBMC, but you'd have to run the latest SVN version (like Dharma Beta 2). If you're able to give that a try and report back that would be good. If it's still an issue in Dharma Beta 2 I'll try to take a look at the code and see what's going on.

Thanks,
Harry

Maybe I've been out of the loop too long. Where is the code that fixes the FPS for interlaced content. Or maybe you are looking at the code which had a bug in it that I just fixed.

[Harry Muscle]

Maybe I've been out of the loop too long. Where is the code that fixes the FPS for interlaced content. Or maybe you are looking at the code which had a bug in it that I just fixed.

No you weren't out too long ... what I was referring to was the code that you actually changed a bit in http://trac.xbmc.org/ticket/10234. I guess I shouldn't have referred to it as a "fix", it's more a educated workaround.

Thanks,
Harry

[GregoryK]

Thanks for the info and the patch. I will wait until the next beta release to try it, but appreciate the help!

/Greg

[outleradam]

Can someone crack the whip on Billy? I just updated ppa:team-xbmc-svn and it's back about 200 revisions. I can't wait to try this out, but I have to wait for a PPA because this is a family machine.

[Harry Muscle]

Can someone crack the whip on Billy? I just updated ppa:team-xbmc-svn and it's back about 200 revisions. I can't wait to try this out, but I have to wait for a PPA because this is a family machine.

No offense, but everyone here does this on their spare time and I'm pretty sure no one wants to be told to hurry up. If you really don't wanna wait just compile it yourself from code. If you don't wanna install lots of apps on the family machine, download VirtualBox, install XP, install all the stuff required to compile and voila, an upto date SVN version of XBMC with only one extra app installed on the machine which you can uninstall easily when done.

Thanks,
Harry

[davilla]

Billy takes offense if pushed. He will let Timmy out of the box and that's when things get very strange.