Posts: 42
Joined: Feb 2005
Reputation:
0
thanks for the link to the patch. i will look at it. it looks like it was thought to be to dangerous to implemnt in the fashion the patch suggested. i don't see how having the ablity to delete in my videos is any more dangerous then having the ability to delete in my files. again thanks for the link.
Posts: 48
Joined: Oct 2004
Reputation:
0
princi
Junior Member
Posts: 48
well, guys....grab a hold of build 0531 and guess what:
you can delete files directly without having to go into my files.
*huge* thank you to the xbmc devs who implemented that request.
:bowdown:
Posts: 266
Joined: Jun 2004
Reputation:
1
what about the ability to be able to do this on network shares?
Posts: 22
Joined: Jun 2004
Reputation:
0
i guess the topic really says it all... i'm not sure if this should be a feature suggestion to the xbmc team, or skinners though (yeah, i'm ignorant)
a 'delete' option on the context menu everywhere would be great... weather you're in videos, pictures, or music.
also... the present delete command seems to not like deleting folders sometimes, though sometimes it does, yet i can't figure out what's different each time... sorry i can't narrow this down.
Posts: 7,172
Joined: Dec 2003
Reputation:
4
kraqh3d
Retired Developer
Posts: 7,172
that is not skinnable. (actually, the context menu itself is only skinnable to the point where you define a few images which make up the box and the buttons.)
the items in the context menu are hard coded into the source code. it was added by someone to movies section, but no where else as yet.
i just added file deletion to the context menu when at the "playlists" screen (its not in cvs yet), which got me thinking about this in a more general sense.
i've been considering adding a new option to the settings for all three media windows to enable deletions, defaulting to off because i think its somewhat dangerous. this way, only those users who want such a feature can enable it.
Posts: 22
Joined: Jun 2004
Reputation:
0
that'd be great. i didn't even consider making it optional, since i'm really the only person using my box... but it definately makes a lot of sense in a family situation.
thanks
Posts: 7,172
Joined: Dec 2003
Reputation:
4
kraqh3d
Retired Developer
Posts: 7,172
done. each media window has an "allow file deletion" option in settings. enable it for a "delete" item in the context menu.
there is no recursive folder deletion, so a folder must be empty for it to be deleted.
Posts: 835
Joined: Feb 2004
works a treat cheers will recursive ever go in for delete
Posts: 10,520
Joined: Sep 2003
Reputation:
10
Gamester17
Team-XBMC Forum Moderator
Posts: 10,520
2005-07-26, 13:05
my 2 cents; recursive delete is good to have in the "my files" file-manager, but too dangerous to have in the media-sections like "my videos" and "my music" :hmm:
Posts: 7,172
Joined: Dec 2003
Reputation:
4
kraqh3d
Retired Developer
Posts: 7,172
from what i can tell, the filemanager doesnt seem to support recursive delete either.
and xhack brought something to my attention. he did the initial support for deletion in movies files. he also added an action which needs to be retrofitted to support the setting, which i'll backport to the other windows.
also, it may need a little tweak to prevent the delete option from coming up in the movie database views.
** update **
i fixed the use of the delete action. now you can assign a remote or gamepad button to delete and use it instead of the context menu. (file deletion must be enabled for it to work obviously.)
i also made sure that delete doesnt work unless when at a files window (with the of movies from the database while at title view which elupus added shortly after my initial commit.)
i'll likely be making some changes on the weekend to reduce the amount of duplicated code. dont worry, it wont change any of the functionality, it'll just clean up the code.
Posts: 835
Joined: Feb 2004
filemanager does have recursive delete, and because there is an option to turn off setting and its off by default i though it would be fine to have recursive delete, id like it to delete at least a folder and stuff in it even if it only did one folder deep
cheers
Posts: 26,215
Joined: Oct 2003
Reputation:
187
i'm thinking of adding an "advancedsettings.xml" file to xbmc.
this will include all options/settings that are either possibly harmful, or overly trivial to include in the gui (ie the gui should be reserved for only settings that the majority of people need. imo we need to go through and reduce a lot of them and just have better defaults).
the allow deletion could go in the advancedsettings.xml (defaulted to off).
this has the benefit of freeing up 3 settings slots (one in each view) as well as making the delete that much harder for the normal user to enable.
there'll obviously still be a yes/no dialog popup, and it'll be easy enough to have a second one popup on the start of the deletion of a folder if people thing that is necessary (i don't, but i'd never use it anyway)
other settings, such as thumb switching percentage in my pictures, for which there is no gui option, and stuff such as subtitle colorings, and even custom zoom modes etc. can be added to this new settings file. these settings will not be editable from the gui at all - the file will be read-only.
i just need a good suggestion of where to place the file so that people can easily avoid overriding it when upgrading. i think the albums/ folder (which can probably be renamed to userdata/) might be a good place.
