outleradam Wrote:Harry, I noticed that this is directed towards the user rather then "generated" jobs. Is there a problem with adopting the format into future releases of mythicalLibrarian?
I would like to see a example or a format like laid out here in this link http://wiki.xbmc.org/index.php?title=EDL...rt#Comskip
Since you are basically setting a new standard, an ISO of sorts, this should be very well documented. Please consider starting a new wiki page like I did here for cleanliness of the mythcialLibrarian documentation. http://wiki.xbmc.org/index.php?title=Myt...n_UserJobs
The only real example I've found is this:
Code:
1234 1:23:45.678 av
33.444 123456798 c
9999 s
1111 2222 av
3333 4444 c
5555 s
23.978 f
It leaves questions like; Is framerate required? What is the extension?
Basically, this looks like a combination of MythTV EDL (framerate) and MPlayer EDL (Time), with the user friendliness of using letters instead of numbers.
So, from what I'm seeing here, it looks like it would be easy to do something like this. Basically, let me get this straight.
Say, commerical is from frame 10000-20000, I could go like this:
Code:
9940 s
9980 20000v
10000 20000c
Which should first give the user a visual warning that a commercial is being skipped, then skip the commerical. If the user decides that the commercial is skipped in the wrong spot, he/she can hit the previous button and jump to the scene marker?
Now, assuming that the commercial was not there, and the user decided that they did not want to skip that part, is there a provision that upon second execution, the Video blank and the skip will not be executed?
The format you mention is what I had originally intended to implement, but dteirney thought it would be best to not create yet another EDL file format since there's already 4 (although granted, none of them are as flexible as the one I proposed
). If you look back a few posts I had a conversation going back and forth between the two of us where we decided it would probably be best to expand the existing MPlayer EDL file format to allow specifying frame numbers (since it's already the most flexible of the formats it made sense to add any new features to this file type). Currently as things stand, the new format would be identical to what's detailed in wiki on MPlayer EDL, but it also would allow specifying HH:MM:SS.sss instead of just seconds and frame numbers by preceeeding the frame number with the # symbol (ie: #1234). Also I've added some error correction code so that if a user specifies only one time for a scene marker it won't fail (since only one time is actually needed).
Currently it's not possible to specify a frame rate in the file. There's no problem to code that feature in, but we'd have to come up with an acceptable and standardized method of doing that, that most can agree on. Although in most situations one wouldn't have to specify frame rate information, it's only needed if XBMC doesn't detect it correct and frame numbers are used instead of time.
If the latest patch gets accepted, the second example you show would look something like this:
#0 #9940 2
#9980 #20000 0
#10000 #20000 3
Explanation:
First Line: 2 = scene marker action at frame 9940, this line can also be written without the first #0 which normally gets discarded anyway
Second Line: 0 = cut action (both video and audio) between frame 9980 and 20000
Third Line: 3 = commercial break action between frame 10000 and 20000
You could also use a combination of HH:MM:SS.sss, seconds, and frame numbers if you wish so the first example you showed would now look something like this:
#1234 1:23:45.678 0
33.444 #123456798 3
#0 #9999 2
#1111 #2222 0
#3333 #4444 3
#0 #5555 2
Again, the two scene markers can be written without the first #0 and the code will compensate. Also the frame rate information was left out since it's not possible to add that yet, unless we come up with a standardized method to do that.
Hope this help a bit.
Once the patch is accepted I'll add/modify stuff on the wiki to explain the new format, etc.
Thanks,
Harry