[adammw]

Hi,
I'm trying to set a repository on googlecode. So far, I thought I set it up correctly in that I have created a domain/folder for all the files, and created the required addon. In XBMC, the thing displays ok but as soon as I try to install something it fails, in that XBMC refuses to download the zip properly and only get 0 bytes. I'm not sure if this is to do with chunked encoding or the https, but it seems to me like a bug that this doesn't work. What is the best way to get this repo working?

Thanks,

[jmarshall]

Give us a link to your addon.xml for your repository, and where the addons.xml resides.

[adammw]

Hi,
Just got your PM so it might not be such an issue now, but if this is a bug we should at least try to fix it for other repos using GoogleCode.

The addons.xml file was in the directory I just gave, but anyway it's https://repo.xbmc-catchuptv-au.googlecod...addons.xml
The repo's addon.xml is inside the zip at https://repo.xbmc-catchuptv-au.googlecod...latest.zip

I don't think it's the HTTPS as I've also tried it as unsecure http, I expect it's more to do with the handling of chunked encoding in FileCurl, as changeset 19064 seems to explictly set the length to '0', which is reported in the xbmc debug logs rather than actually waiting for the entire response.

[jmarshall]

I believe you are 100% on the money, yeah. CFile::Cache() requires GetLength() > 0 which is broken by that CFileCurl change.

Two things to consider here:

1. CFile::Cache() should probably work with GetLength() not returning > 0 to begin with.
2. CFileCurl needs to be reviewed to see why this change is needed, or whether it needs to be quite so general.

I've created a trac ticket here:

http://trac.xbmc.org/ticket/10257

Feel free to add anything that I may have missed. Interestingly, other googlecode based repositories seem fine, eg the xbmc-addons repository. I wonder if it's due to the use of mercurial?

Cheers,
Jonathan