[WIP] XBMC Flicks (Netflix Addon) Development Thread - Developers Only!

  Thread Rating:
  • 1 Votes - 5 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Post Reply
fekker Offline
Posting Freak
Posts: 1,545
Joined: Oct 2008
Reputation: 30
Post: #41
fade23 Wrote:On 1.03, with Expand TV Episodes Automatically, the script is completely failing when I go to My Instant Queue. Here's the log:

Code:
12:06:34 T:6088 M:1384828928   ERROR: Error Type: exceptions.TypeError
12:06:34 T:6088 M:1384820736   ERROR: Error Contents: getMovieDataFromFeed() takes exactly 9 arguments (8 given)
12:06:34 T:6088 M:1384783872   ERROR: Traceback (most recent call last):
                                              File "C:\Users\rglass\AppData\Roaming\XBMC\addons\plugin.video.xbmcflicks\default.py", line 26, in ?
                                                import resources.lib.menu as menu
                                              File "C:\Users\rglass\AppData\Roaming\XBMC\addons\plugin.video.xbmcflicks\resources\li​b\menu.py", line 146, in ?
                                                getInstantQueue()
                                              File "C:\Users\rglass\AppData\Roaming\XBMC\addons\plugin.video.xbmcflicks\resources\li​b\iqueue.py", line 606, in getInstantQueue
                                                getUserInstantQueue(netflixClient,user)
                                              File "C:\Users\rglass\AppData\Roaming\XBMC\addons\plugin.video.xbmcflicks\resources\li​b\iqueue.py", line 421, in getUserInstantQueue
                                                curX = getMovieDataFromFeed(curX, curQueueItemTvE, pq, yesYear, yesSummary, realpath, True, netflix)
                                            TypeError: getMovieDataFromFeed() takes exactly 9 arguments (8 given)
12:06:34 T:7384 M:1385254912   ERROR: XFILE::CDirectory::GetDirectory - Error getting plugin://plugin.video.xbmcflicks/?mode=10
12:06:34 T:7384 M:1385254912   ERROR: CGUIMediaWindow::GetDirectory(plugin://plugin.video.xbmcflicks/?mode=10) failed

If I turn that option off it build the queue fine. Is this meant to work such that it will list each episode out in the top level the queue? I think the ideal behavior here would be to mimic the TV Series library screens, where you get the TV Show listed in the main queue level (alongside any movies), and then when a series is selected open a new window with the list of episodes.

Good catch on that one, i'll get it fixed up as I need to clean up those calls anyway. On line 421 add a , False to the parameters.
i.e.
curX = getMovieDataFromFeed(curX, curQueueItemTvE, pq, yesYear, yesSummary, realpath, True, netflix, False)

The end idea is that when auto-expand is enabled, the tvshow item in the main menu becomes a folder, when clicked it opens up and shows the episodes for that. I haven't got the submenu's sorted yet for those.

The instant queue could also split up into movies and tv shows (i.e. when the queue is opened, it's like the library mode where it'll show movies as a folder and tvshows as a folder.) not sure on that yet.

I've got a few tricks i wanna do first with the instant queue and plot's (grabbing the rss feed of the users instant queue for the summary data as it'll be much much faster), then saving that out to a local file (either a full .nfo file, or just a .summary file, not sure yet) The .nfo would be cool as the directory could be loaded as a source into xbmc and appear in the library along side of the local media.
(This post was last modified: 2010-12-09 21:19 by fekker.)
find quote
scottmcclung Offline
Junior Member
Posts: 8
Joined: Jun 2009
Reputation: 0
Post: #42
Quote:Notes: if using OSX, pick it in the addon settings, that changes how it handles the initial browser open so that auth should work (please test)

I'm sorry I don't have time to dig into this a little further tonight but I did test this on OSX and it appears that the flag is not getting picked up. I've chosen OSX in the addon settings but as you can see from the log, it's reading it as false.
I added a line to print the value of OSX so you can see that in the log.
http://pastebin.com/Cxbai723
find quote
fekker Offline
Posting Freak
Posts: 1,545
Joined: Oct 2008
Reputation: 30
Post: #43
I was calling the wrong setting (had OSX in one area and osx in another).. i've fixed that up

I've changed over to the v2.0 api calls now

version 1.0.4
http://rapidshare.com/files/436219141/pl...flicks.zip

Known issues: ratings will show the Netflix rating beside the name for tv shows and some movies, I'm still trying to find the list of what each of the numbers mean.. if you see a number in there beside the name instead of a rating, it means i don't know what the mpaa equiv is.. post them as you find them and i'll add them in there

Genre: Not yet parsed out

New Shows only contain real data for the name, poster and Plot, no other data is available in the feed
find quote
scottmcclung Offline
Junior Member
Posts: 8
Joined: Jun 2009
Reputation: 0
Post: #44
The OSX fix works great. Safari launches to the authentication page as expected.
Thanks for the great work fekker.
find quote
fekker Offline
Posting Freak
Posts: 1,545
Joined: Oct 2008
Reputation: 30
Post: #45
I was thinking of breaking down the Instant Queue abit

Instant Queue - Movies (shows only movies)
Instant Queue - TV Shows (shows only TV Shows)

With the TV Shows -
It could either be a list of TV Shows (when clicked they will pull the list of episodes for that show)
If it's a list of TV Shows - it basically just looks like a folder, then when opened up it'll show the episodes

OR

A Full List of the actual episodes All of those shows contain

-----

Or I can just leave it with it showing everything when you click on Instant Queue and keeping the User Option to auto-expand the episodes

thoughts?
find quote
Fluthy Offline
Junior Member
Posts: 6
Joined: Jul 2010
Reputation: 0
Post: #46
Hey fekker, I would love to try this out. Where can I download, all of the links appear to have maxed out the number of downloads?
find quote
fekker Offline
Posting Freak
Posts: 1,545
Joined: Oct 2008
Reputation: 30
Post: #47
https://github.com/downloads/spudsdude/X...flicks.zip

I'm going to go ahead and release it the way it is, I think it works well, it's gotten better then the initial release in speed and has the options that I wanted to put in there.

For tv shows, i decided to just expand to show the episodes in the same folder (i like the way that works out, so that's the route I took)
(This post was last modified: 2010-12-14 01:24 by fekker.)
find quote
fekker Offline
Posting Freak
Posts: 1,545
Joined: Oct 2008
Reputation: 30
Post: #48
We can close out this thead, i've released version 1.0.5 under the general plugins thread

Thanks to everyone for the ideas and assistance, enjoy the plugin.
find quote
fade23 Offline
Junior Member
Posts: 40
Joined: Oct 2010
Reputation: 0
Post: #49
fekker Wrote:With the TV Shows -
It could either be a list of TV Shows (when clicked they will pull the list of episodes for that show)
If it's a list of TV Shows - it basically just looks like a folder, then when opened up it'll show the episodes

OR

A Full List of the actual episodes All of those shows contain

I prefer the former, as that keeps it consistent with navigating shows in Library mode. Even better if you could drill down by season as well.
find quote
fekker Offline
Posting Freak
Posts: 1,545
Joined: Oct 2008
Reputation: 30
Post: #50
fade23 Wrote:I prefer the former, as that keeps it consistent with navigating shows in Library mode. Even better if you could drill down by season as well.

I'll prob make it an option in the next build, just waiting to see if i missed anything with 1.0.5 before I make more changes. The first method I came up with didn't work out as it would re-request all the episodes one by one, which was slow. I'm sure there's a way to do it with the folders, I stumbled on something that kinda showed some data, but it didn't work as expected, and decided just to scrap that part and release.

For most shows I could show the season numbers (from the title), but others said stuff like "the eleventh year", and not season 11. Mythbusters in particular also didn't have much season relation as they group the episodes into bundle like things, instead of seasons.
find quote
Post Reply