[MOD] Night.Purity

zwat · 2010-12-06 02:08

another issue that i'm not sure of. dolby digital and ac3 flags are showing on movies with ac3 codec. should both show or just the ac3?

KiSUAN · 2010-12-06 02:56

The thing is this, DD is the commercial name of AC3, so technically they are the same. As now the icon for AC3 is setup to be shown only when its less than 6 channels and the DD always. I didn't realize that I missed the 6 channel condition for DD so thank you to point me out, I will change it to show only DD when 6 Ch as people associate DD with surround or alike.

Besides this will reduce the number of flags in some movies that was a little hi, as now they tend to be between 6 and 7, before 6-8.

Update:

- Corrected Flags showing in Video Nav

- Corrected "Director/Writer/Genre/..." showing in Video Nav

- Corrected some Flag showing wrong

- Font Clean up

mcborzu · 2010-12-07 03:59

You can check my git but I added a fix for the frame/back showing when not supposed to like so:

[Image: level_up_flag.png]

Code:

<control type="image">

            <description>Video rez Image</description>

            <width>62</width>

            <height>46</height>

            <aspectratio>keep</aspectratio>

            <texture>flagging/back_flag.png</texture>

            <colordiffuse>BackDiffuse</colordiffuse>

            [b]<visible>!IsEmpty(ListItem.VideoResolution)</visible>[/b]

        </control>

Code:

<control type="image">

            <description>Audio Channels Image</description>

            <width>62</width>

            <height>46</height>

            <aspectratio>keep</aspectratio>

            <texture>flagging/back_flag.png</texture>

            <colordiffuse>BackDiffuse</colordiffuse>

            [b]<visible>!IsEmpty(ListItem.AudioChannels)</visible>[/b]

        </control>

Code:

<control type="image">

            <description>Aspectratio Image</description>

            <width>62</width>

            <height>46</height>

            <aspectratio>keep</aspectratio>

            <texture>flagging/back_flag.png</texture>

            <colordiffuse>BackDiffuse</colordiffuse>

            [b]<visible>!IsEmpty(ListItem.VideoAspect)</visible>[/b]

        </control>

Also due the same on the frame section...

KiSUAN · 2010-12-07 04:11

Crap, already did that but in the hard way, took every view that was showing and didn't suppose and do it via My...xml or level (tvshows) for every grouplist. And still my solution didn't cover movisets because I was too lazy to research how to do it.

Thank you, guess I will have to "roll back" that changes and add your solution as its much elegant.

Also corrected "Director/Writer/Genre/..." showing in Video Nav, as I stated in the last update right before your post. Don't know if you have a better way for that one too.

mcborzu · 2010-12-07 04:20

Also I got a fix for selecting two flags at same time:

Code:

<control type="radiobutton" id="519">

    <include>skin_settings_labels</include>

    <label>Use Original Type Flags</label>

    [b]<onclick>Skin.Reset(vanilla_flags)</onclick> [/b]

    <onclick>Skin.ToggleSetting(original_flags)</onclick>

    <selected>Skin.HasSetting(original_flags)</selected>

</control>

Still going thru and 2x checking stuff, forgot to mention it's not on GIT this second but in about 2hrs or so..

KiSUAN · 2010-12-07 04:43

Ok, thought that one but didn't have a clue how to do it, so i leave it that way and didn't even dear to select two just to don't have remorse (one thing is suspect something could go terribly wrong and another knowing) , I'm a bad person I now Blush

On a second thought i will keep my solution and add yours (flags showing wrong), just in case, because I think that with some of the visual conditions Dvd and other that I included path icons will show.

KiSUAN · 2010-12-08 03:40

Update:

- Flag poss change in views & Preview at selection.

m3g4tr0n · 2010-12-10 03:14

when enabling tv tunes, this shows up

[Image: capturebv.jpg]

KiSUAN · 2010-12-10 04:10

I been postponing trying Tv Tunes, guess I have to do it now, anyway I didn't touch anything related to it knowing, perhaps I messed up something. Have you checked if night does the same?

ppic · 2010-12-10 04:27

you have a skin property to know if a theme is palying, just deactivate standard music playing stuff if it's true.

zwat Fan Posts: 724 Joined: Jul 2009 Reputation: 2 Location: Norway	2010-12-06 02:08 Post: #11 another issue that i'm not sure of. dolby digital and ac3 flags are showing on movies with ac3 codec. should both show or just the ac3? Currently addicted to Night. Watch this teaser and join the forum. Get and request your ClearLOGOs from the ClearLOGO site and forum Try my changes to the Night skin if u like how they looks
	find quote

KiSUAN Fan Posts: 536 Joined: Oct 2010 Reputation: 3 Location: Montevideo, Uruguay	2010-12-08 03:40 Post: #17 Update: - Flag poss change in views & Preview at selection. Night [MOD] Purity [url=http://forum.xbmc.org/showthread.php?tid=86759"] Purity Media Flags & RD XBMC Icon [/url] [url=http://forum.xbmc.org/showthread.php?tid=99554"] Film/Movie/Game Studio Flags Repository [/url]
	find quote

m3g4tr0n Senior Member Posts: 139 Joined: Jan 2010 Reputation: 0	2010-12-10 03:14 Post: #18 when enabling tv tunes, this shows up
	find quote