2010-12-18, 01:41
Hi All,
Having used an original XBox running XBMC for some time I've moved to an Asroc 330HT using the live distribution and thought now might be a good time to start contributing...
When using locally attached USB drives you'll find that XBMC will list the drive under Videos with no means to lock it from prying junior eyes. I would rather exclude this from unrestricted browsing, instead only allowing access to sources I have added, pin protecting age restricted content.
In xbmc/FileSystem/VirtualDirectory.cpp there's a routine called GetRemovableDrives() which gets called if a flag, m_allowNonLocalSources, is true. This is always set true (at line 48), and there's no way to set it false without rebuilding unfortunately. If set false then removable drives (USB FLASH and hard drives) will not be listed under source lists. Pity this isn't settable from an XML configuration option. Of course there's no reason why there shouldn't be...
So a bit of rebuilding and I'm now running the latest version from SVN tweaked as desired. The following addition to ~/.xbmc/userdata/advancedsettings.xml disables external (USB) media display in the source menus.
<nonlocalsources>false</nonlocalsources>
So, two questions really:
1. Do you guys agree that the above mod is worthwhile to make XBMC more secure in a family environment?
2. If (1) is a "yes", how should I go about contributing my changes?
Thanks,
Steve
Having used an original XBox running XBMC for some time I've moved to an Asroc 330HT using the live distribution and thought now might be a good time to start contributing...
When using locally attached USB drives you'll find that XBMC will list the drive under Videos with no means to lock it from prying junior eyes. I would rather exclude this from unrestricted browsing, instead only allowing access to sources I have added, pin protecting age restricted content.
In xbmc/FileSystem/VirtualDirectory.cpp there's a routine called GetRemovableDrives() which gets called if a flag, m_allowNonLocalSources, is true. This is always set true (at line 48), and there's no way to set it false without rebuilding unfortunately. If set false then removable drives (USB FLASH and hard drives) will not be listed under source lists. Pity this isn't settable from an XML configuration option. Of course there's no reason why there shouldn't be...
So a bit of rebuilding and I'm now running the latest version from SVN tweaked as desired. The following addition to ~/.xbmc/userdata/advancedsettings.xml disables external (USB) media display in the source menus.
<nonlocalsources>false</nonlocalsources>
So, two questions really:
1. Do you guys agree that the above mod is worthwhile to make XBMC more secure in a family environment?
2. If (1) is a "yes", how should I go about contributing my changes?
Thanks,
Steve