XBMC-PHP-RPC - a PHP JSON-RPC library supporting HTTP and TCP

Hi Mindzai,

I noticed if i send a request with a string where XBMC is expecting an integer it hangs the JSONRPC interface, i thought maybe you could catch that in your wrapper throwing an exception (or just converting the value to intval).

eg


stops XBMC from responding on the JSON interface.

dann0 Wrote:Hi Mindzai,

I noticed if i send a request with a string where XBMC is expecting an integer it hangs the JSONRPC interface, i thought maybe you could catch that in your wrapper throwing an exception (or just converting the value to intval).

eg

PHP Code:

$badvar = array('start' => $_POST['start'], 'end' => $_POST['end']);

try{
        $response = $rpc->AudioLibrary->GetArtists($badvar);
} catch(XBMC_RPC_Exception $e) {
        die($e->getMessage());
} 


stops XBMC from responding on the JSON interface.

The issue is that the wrapper doesn't have any way of knowing the correct data type of the parameters of each RPC method, so it would have to convert anything that looked like a number (is_numeric) into the appropriate data type. This may then cause the opposite problem of converting what should be a string into a number.

Personally I think it's either up to the client code, or XBMC itself to handle this sort of thing. I would not anticipate XBMC would hang in this situation myself, I'd expect it to handle type conversion but obviously this isn't the case, so I'd say it's something the client code should do (since by definition you know in client code which method you are calling and what to pass it).

Regarding your other issue with albums not being retrieved correctly when using start and end parameters, I couldn't reproduce the problem. Admittedly my music library on my test machine only has a few albums, but they always came back right with every value of start and end I supplied.

Hi,

first of all - thanks to this wonderful Wrapper, it's very helpful.
I've troubles with some methods, when I'm calling the php, i.e.: doesn't work for me. I got the error "Failed to execute method."
It is similar for other calls (AudioPlayer.StartPause, ...)

for some methods like all in XBMC namespace

I got "Invalid params."

Other calls like both in the example.php works well.
I don't know what I'm doing wrong here.

Can anyone help on this issue or have similar problems?

Thanks,
Philipp

I'm using this:

$result = $xbmcJson->JSONRPC->Announce(array('message' => 'My message', 'sender' => 'testsender'));

but i get an exception 'ERROR: Invalid params'

can anyone confirm this?

I've solved it adding this line:

Quote:if (is_array($params)) $params = $params[0];

on the first line in rpc function. This way it worked fine... hope this helps to other people having this issue

@superflip:

I can't reproduce this except for the "Invalid params" response from XBMC->Play(). Not sure why that is as no params are documented for that method. Everything else you mention appears to be working fine here. Can you let me know if you figure out any more info which may point to the cause please?

Edit:

Seems you need to tell it what to play, which makes sense!


If you're just trying to play (after pausing for example), you'd need to use VideoPlayer->PlayPause() (or the equivalent for audio and picture players).

@fidoboy:

I can't reproduce your error either. Can you give me the filename and line of where you are editing please?

There is only a function called rpc inside the class xbmcJsonRPC. Locate that function and then add the line in my previous post. I can't remember the name of the file (cause i've renamed it) but there is only one for this library.

You don't need to specify what to play, the parameter is optional. But without my fix, without that line, parameters doesn't work.

Ah then you're not using my code You must be using another wrapper. I was confused as I already have code to manage varying param configurations.

The only way I could get Play() to work was adding some params specifying what to play. Perhaps the wiki needs to be updated.

Hi Mindzai,
I need to contact you via private email. Can you let me know how?

Thanks

You can reach me by email at karl@karlrixon.co.uk.