Hi,
In line with the HOW-TO at http://wiki.xbmc.org/?title=HOW-TO_submit_a_patch I'm starting this thread to raise awareness of ticket/patch TV Shows exposed from locked sources using shared libraries as it seems to have been overlooked.
When having a number of profiles in which both <hasdatabases>false</hasdatabases> and <hassources>true</hassources> are defined for one or more users, such users are able to view TV Shows from sources which have been explicitly removed from their profiles. Under the TV Show listing they are able to see the names of such shows, and under the rececently added episodes they are even able to view the episodes.
Thus, for example, if you have a library with two sources, one containing adult themed TV shows, and the other cartoons for the kids, you might well setup a login for the kids which would explicitly remove the adult source. However as both login profiles share a common library, the "recently added" and such queries to the media library return a full list of matching TV shows, even those which are in the adult source. There is already functionality to filter media library query results by access rights for Movies, however this functionality is not present for TV shows, so as a consequence such "recently added" TV shows are viewable through the kids' login.
This issue has been seen using sources on local drives. It may or may not be a problem on dynamically mounted remote shares, however the fact that a fix has already been applied for Movies shows that it has affected others in the past.
This patch applies the same filtering to the TV shows as already exists for Movies. I would therefore anticipate it being accepted as non-contentious.
This patch is of a similar class to Disable/Show removable media in file lists in that it controls access to media is a family environment.
Comments?
Steve
In line with the HOW-TO at http://wiki.xbmc.org/?title=HOW-TO_submit_a_patch I'm starting this thread to raise awareness of ticket/patch TV Shows exposed from locked sources using shared libraries as it seems to have been overlooked.
When having a number of profiles in which both <hasdatabases>false</hasdatabases> and <hassources>true</hassources> are defined for one or more users, such users are able to view TV Shows from sources which have been explicitly removed from their profiles. Under the TV Show listing they are able to see the names of such shows, and under the rececently added episodes they are even able to view the episodes.
Thus, for example, if you have a library with two sources, one containing adult themed TV shows, and the other cartoons for the kids, you might well setup a login for the kids which would explicitly remove the adult source. However as both login profiles share a common library, the "recently added" and such queries to the media library return a full list of matching TV shows, even those which are in the adult source. There is already functionality to filter media library query results by access rights for Movies, however this functionality is not present for TV shows, so as a consequence such "recently added" TV shows are viewable through the kids' login.
This issue has been seen using sources on local drives. It may or may not be a problem on dynamically mounted remote shares, however the fact that a fix has already been applied for Movies shows that it has affected others in the past.
This patch applies the same filtering to the TV shows as already exists for Movies. I would therefore anticipate it being accepted as non-contentious.
This patch is of a similar class to Disable/Show removable media in file lists in that it controls access to media is a family environment.
Comments?
Steve
