Removal of Files views - need skinner comments

3. when marking an item as watched in the fanart viewmode it doesn't perform the usual scroll animation to the next item in the list. It's more like it refreshes the whole view and jumps directly to the next item.

Regarding 1, is it just the issue with "can't find the item" on attempt to playback or are there other issues (eg info isn't shown for the items etc?) Check out the added columns (c21 in movies, c18 in episodes etc.) and check the paths listed there - that's the path to the directory item that represents the item to play (movie folder for instance).

Cheers,
Jonathan

The info that is displayed in the "Media Info" view is present, though I can not bring forth the information window by pressing "i".

c21 in movies is, I guess, production country, c22 on the other hand is the path to the file.
c18 in episode is however the full path to the file, but episodes still won't play.

the contents of a c18 row in episodes:
'smb://HTPC/TV-shows/Bones/Bones S06E01 720p WEB-DL DD5.1 H264-NFHD.mkv'

I set up a test db on my server for testing purposes. And then I built a new library using this build. And the resulting database is working but has the same column info in c22/c18 as the upgraded one. I guess the problem lies somewhere else.

the log says

Quote:02:51:10 T:4184 M:2480533504 WARNING: XFILE::CFileFactory::CreateLoader - Unsupported protocol(1/smb) in 1/smb://HTPC/Movies/

Ok - it'd be worth grabbing a debug log from you failing to start an episode/movie - just to see whether it's actually a db problem or is just something I haven't caught yet.

Okay, a bunch of fixes have been pushed. Basically all of the above except for those issues caused by the background loading of extra info (eg watched filtering won't work, items don't show immediately etc.)

I'll see if I can get things a little bit faster so that we can just grab the info from the database with the dir fetch.

Cheers,
Jonathan

I would like to throw my 2 cents work in here on actual layout. What you have done here is great jmarshall but I think it would be nicer if it was implimented the same way as has been discussed in the other library threads.

Remove the actual files node and have the sources in the library root. And have the ability to add smart playlists too root to replace the current nodes (if needed)

Yup - Plan is to first get the Files node in there (and files view out of the way).

Then the actual layout will be made configurable (probably just via XML - not sure if we'll try and UI it), allowing you to pop some of the sources in library root if you like. Similarly, the "Movies" and "TV Shows" overview nodes will also be configurable (and you'll be able to add other folders should you want them for smartplaylists and the like).

Sound good?

Cheers,
Jonathan

jmarshall Wrote:Hi guys,

On my github, you'll find a files_in_lib branch which removes the use of MyVideo.xml, replacing it with a Files node in the root of the

OK, I tested on my old win notebook with build Jezz_X sent. All settings were left on defaults and I added my sources (on NAS) using context menu as add videos didn't seam to work.

On NAS, each kid's movie have it's own separate folder with folder.jpg. IFAICT, folder.jpg and fanart.jpg are not being picked up as thumbs. I can't comment further on this as it is all I use in files mode.

It's nice that we are to get rid of library vs files dualism, though, If I should comment on way Files are going to be merged, I would have to say I don't like it much. I expected "Sources" item along with Genres, Titles, Directors... OTOH, you said it's the first step so maybe it will be completely different in the end.

ok, so here is a log from the following setup:
mysql server is on computer1
computer1 has created the database and populated it with a couple of movies. Using dharma build.
computer2 is running the build from before your most recent changes and after it has run, the database xbmc_video_test2 doesn't work with either the old or the new build.


http://pastebin.com/iAVCTQeP

pecinko Wrote:It's nice that we are to get rid of library vs files dualism, though, If I should comment on way Files are going to be merged, I would have to say I don't like it much. I expected "Sources" item along with Genres, Titles, Directors... OTOH, you said it's the first step so maybe it will be completely different in the end.

My thoughts regarding actual / planned layout from a skinning and usability point of view:

With files merged, I would consider discarding current video root view (videodb://). In order for this to make sense, we would need MyMovieNav.xml (pointing to videodb://1/), MyTVShowsNav (videodb://2/) and MyMusicVideosNav.xml (videodb://3/). One can object that this is not simpler as I'm adding additional xmls but, from my experience, those 3 media types are different enough (especially TVShows poster/banner) so skinner needs to separate code for them even if using only one xml - (MyVideoNav.xml). IMO, this separation can make using of conditions easier (Container.Content() ) and reduce need of using custom xmls (ViewsVideoLibrary.xml) for code readability.

Further, I would move recently added and playlists to each of those sections and add "Sources" and "Search". Sources (aka Files) opens list of added sources and "Search" brings up context sensitive search dialog based on section chosen (Movies, TVShows, MusicVids).

This would also help navigation as it reduces nav steps by one. Current situation with most skins is home page to media jumping, making videodb:// and videodb://*/ use a little difficult and not quite obvious.

I would leave it to skinner's decision to choose if MucisVideos would be separate item in main nav or linked as Music subsection (it opens videodb://3/ in either case).

Just my 2 euro cents :-)