Changes to skinning engine for Eden (and beyond)

  Thread Rating:
  • 1 Votes - 5 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Post Reply
jmarshall Offline
Team-XBMC Developer
Posts: 26,181
Joined: Oct 2003
Reputation: 176
Post: #1
Hi all,

This first post will be used to list the proposed and finished changes to the skinning engine for Eden, to help you all ensure your skins will work well with the release, as well as make sure I give ya'll what you're wanting. Smile

1. Changes that you need to take into account:

1.1 Move the files views inside the library, removing MyVideoFiles.xml and MyMusicSongs.xml.
- video: DONE
https://github.com/xbmc/xbmc/commit/e0f2...5ed78c9b5e
http://forum.xbmc.org/showthread.php?tid=93929
- music:

1.2. Ensure Container.Content is set to appropriate things in all sections. NEED INPUT.
http://forum.xbmc.org/showthread.php?p=729266
http://trac.xbmc.org/ticket/10313

1.3. Make context menu use a grouplist control: DONE
http://forum.xbmc.org/showthread.php?tid=77832

1.4. Change from fixed-resolution folders to arbitrary resolution for skins. IN PROGRESS
http://forum.xbmc.org/showthread.php?p=730587
http://trac.xbmc.org/ticket/11223
https://github.com/xbmc/xbmc/commit/194d...59fe8d34c2

1.5. Add ability to retrieve listings into static content.

1.6. Add ability to set a slider control in any window to handle volume and seeking. DONE
https://github.com/xbmc/xbmc/commit/26aa...bac1e78ef9

1.7 Add skin.art addons to take care of studio icons and weather fanart packs (and perhaps other background packs?)
http://forum.xbmc.org/showthread.php?p=731714

1.8 Added better Container.Foldername for all sections. This gives localized names for all sorts of URL formats, allowing your "breadcrumb" bar to be much easier. Basically just through Container.Foldername anywhere you like to have the folder name of the current listing (localized as required). DONE

1.9 Changed slider nib to respect aspect ratio. It now scales vertically based on the background texture height to control height and then horizontally to match aspect. DONE

2. Things added/fixed that don't necessarily require you to do anything:

2.1. Add Control.GetLabel support to multiimage. DONE
http://trac.xbmc.org/ticket/10069

2.2. Add sort by playcount to music+video views. DONE
http://trac.xbmc.org/ticket/11185

2.3 Add listitem.playcount for music + video. DONE
http://trac.xbmc.org/ticket/3711

3. Things would be nice to have, but may not make it depending on time/patches

3.1. Addition of "skin variables" so that conditional operations are easier. DONE
http://trac.xbmc.org/ticket/10423
http://forum.xbmc.org/showthread.php?tid=94052

Cheers,
Jonathan

Always read the XBMC online-manual, FAQ and search the forum before posting.
Do not e-mail XBMC-Team members directly asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting please make sure you read this first.


[Image: badge.gif]
(This post was last modified: 2011-10-09 00:07 by ronie.)
find quote
mcborzu Offline
Skilled Skinner
Posts: 3,381
Joined: Feb 2009
Reputation: 15
Location: dsf
Post: #2
What about customizable Home items, I've seen posts saying the Devs are thinking about this. Is it a Eden item or more of a "thinking about it" type thing?

Minor requests while I'm here:

1. VideoPlayer.Fanart, would be nice to use a 16x9 image in all views if you're going for a consistent look, or just be different.

2. ListItem.Property(Artist_Description) and ListItem.Property(Album_Description) available on Artist level.

3. Addons stats on Home - Like the ability to show newest addons, updated addons, top downloaded addons in the same type of fashion we do for Recently Added...

[Image: widget]

Check out The Carmichael - A Skin For XBMC

Check out Night - A Skin For XBMC

Check out Unfinished - A Skin For XBMC
find quote
blacklist Offline
Posting Freak
Posts: 814
Joined: Jul 2009
Reputation: 1
Location: Atlanta, Ga, USA
Post: #3
mcborzu Wrote:2. ListItem.Property(Artist_Description) and ListItem.Property(Album_Description) available on Artist level.

+1 Something I've been missing forever!
find quote
sho Offline
Team-XBMC Member
Posts: 4,128
Joined: May 2004
Reputation: 3
Post: #4
Does the playcount stuff belong here?
http://trac.xbmc.org/ticket/11185
http://trac.xbmc.org/ticket/3711


PS do you guys have tickets to back these up?
mcborzu Wrote:2. ListItem.Property(Artist_Description) and ListItem.Property(Album_Description) available on Artist level.

+1 Something I've been missing forever!

Always read the XBMC online-manual, FAQ and search the forum before posting.
Do not e-mail XBMC-Team members directly asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting please make sure you read this first.
find quote
jmarshall Offline
Team-XBMC Developer
Posts: 26,181
Joined: Oct 2003
Reputation: 176
Post: #5
Please post separate requests in either separate trac tickets or separate forum posts - that way this thread doesn't get cluttered with discussion about particular features - you can, ofcourse link to them in here and I'll update the first post to suit.

@mcborzu: Your first request (customizable home), and number 3, rely on feature 1.5 being done first.

@sho - thanks, will add to the list above.

Always read the XBMC online-manual, FAQ and search the forum before posting.
Do not e-mail XBMC-Team members directly asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting please make sure you read this first.


[Image: badge.gif]
find quote
blacklist Offline
Posting Freak
Posts: 814
Joined: Jul 2009
Reputation: 1
Location: Atlanta, Ga, USA
Post: #6
sho Wrote:Does the playcount stuff belong here?
http://trac.xbmc.org/ticket/11185
http://trac.xbmc.org/ticket/3711

PS do you guys have tickets to back these up?

+1 Something I've been missing forever!

I actually did have a ticket long ago, I'll see if I can dig it up. I seem to remember having some discussion with spiff about it at the time.
find quote
Jezz_X Online
Team-XBMC Skinner
Posts: 5,289
Joined: Jun 2006
Reputation: 57
Location: Earth
Post: #7
jmarhsall this was discussed a long time ago so I have no reference links off the top of my head but

Seperate addon downloads for
* weather fanart
* studio icons

so each skin doesn't need to include them

and of course the old debate
expand the thumb cache to allow poster and banner and extra thumbs without direct link hacking
find quote
Hitcher Offline
Skilled Skinner
Posts: 10,635
Joined: Aug 2007
Reputation: 91
Location: Eastleigh, UK
Post: #8
jmarshall Wrote:2.1. Add Control.GetLabel support to multiimage. DONE
http://trac.xbmc.org/ticket/10069

Thanks Jonanthan. Big Grin

Any ETA on the nightlies so I can start re-coding Alaska's home screen?

EDIT: Or could someone please make a build for me?
(This post was last modified: 2011-02-20 16:12 by Hitcher.)
find quote
jmarshall Offline
Team-XBMC Developer
Posts: 26,181
Joined: Oct 2003
Reputation: 176
Post: #9
Nightlies are back on. One should startup in around 10 hours, and will hopefully pop out onto the mirrors Smile

Always read the XBMC online-manual, FAQ and search the forum before posting.
Do not e-mail XBMC-Team members directly asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting please make sure you read this first.


[Image: badge.gif]
(This post was last modified: 2011-02-21 01:03 by jmarshall.)
find quote
igotdvds Offline
Skilled Skinner
Posts: 1,616
Joined: Jul 2009
Reputation: 11
Post: #10
I would like to reference a couple of existing requests.

http://forum.xbmc.org/showthread.php?tid=94052

http://forum.xbmc.org/showthread.php?tid=91328

http://forum.xbmc.org/showthread.php?tid=81923
find quote
bmcclure937 Offline
Fan
Posts: 654
Joined: Dec 2010
Reputation: 5
Location: Ohio
Post: #11
Although I am not a skinner... I would love to see something on the wiki documenting the different "views" available. This is highly useful when creating keymap.xml/remote.xml files for IR remotes.

You need to know the different views in order to tweak the remote functionality and fine tune it to perform as desired. Big Grin
find quote
Hitcher Offline
Skilled Skinner
Posts: 10,635
Joined: Aug 2007
Reputation: 91
Location: Eastleigh, UK
Post: #12
Views are skin specific though.
find quote
jmarshall Offline
Team-XBMC Developer
Posts: 26,181
Joined: Oct 2003
Reputation: 176
Post: #13
You mean windows, not views - these are available already in the skinning section, though it may be out of date.

@Hitcher: http://mirrors.xbmc.org/nightlies/win32/

Always read the XBMC online-manual, FAQ and search the forum before posting.
Do not e-mail XBMC-Team members directly asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting please make sure you read this first.


[Image: badge.gif]
find quote
jmarshall Offline
Team-XBMC Developer
Posts: 26,181
Joined: Oct 2003
Reputation: 176
Post: #14
@igotdvds: I've commented in the threads and/or added to the above list.

Always read the XBMC online-manual, FAQ and search the forum before posting.
Do not e-mail XBMC-Team members directly asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting please make sure you read this first.


[Image: badge.gif]
find quote
mcborzu Offline
Skilled Skinner
Posts: 3,381
Joined: Feb 2009
Reputation: 15
Location: dsf
Post: #15
Created a Ticket for ListItem.Property(Artist_Description) and ListItem.Property(Album_Description) available on Song level.


Also to comment on 1.7 Add skin.art addons to take care of studio icons and weather fanart packs (and perhaps other background packs?):

We're you meaning just regular Movie/TV background packs or something more specific like Genre Images and Genre Fanart type packs?

[Image: widget]

Check out The Carmichael - A Skin For XBMC

Check out Night - A Skin For XBMC

Check out Unfinished - A Skin For XBMC
(This post was last modified: 2011-02-22 04:29 by mcborzu.)
find quote
Post Reply