Changes to skinning engine for Eden (and beyond)

  Thread Rating:
  • 1 Votes - 5 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Post Reply
pecinko Offline
Donor
Posts: 3,773
Joined: Dec 2008
Reputation: 51
Location: Prague / Belgrade
Post: #46
pieh Wrote:Currently it's not added as overlay icon (reason for that is that 1 item can be already watched and still can be in progress - someone is watching it second time). This is how it works under the hood and I wasn't changing it.

That is true. However, I would be happy if the team would consider it from the other point of view - when you what to quickly distinguish what items you started to watch but you did not finish, regardless of the fact if you watched them before i.e. If I'm watching an already watched item in progress status is more helpfull. Item will be marked as watched again once I'm finished.

My skins:

Amber
Quartz

find quote
pieh Offline
Team-Kodi Member
Posts: 672
Joined: Aug 2010
Reputation: 13
Location: Poland
Post: #47
It depends - skinner may choose to include both watched flags and mark item as "in progress" so adding it as overlay icon isn't really good option for flexibility (f.e. http://dl.dropbox.com/u/28792047/xbmc/screenshot037.png - my proof of concept sshot, don't worry - it's not in master ;P). You can use 2 controls with different visiblity conditions to get desired effect (and hopefully soon You will be able to use just 1 control and skin variable )

Always read the XBMC online-manual, FAQ and search the forums before posting.
Do NOT e-mail Team-XBMC members asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting, make sure you read this first

My previous forum/trac nickname: grajen3
find quote
pecinko Offline
Donor
Posts: 3,773
Joined: Dec 2008
Reputation: 51
Location: Prague / Belgrade
Post: #48
@pieh

Thanks for added info, now I know what to do in the skin.

My skins:

Amber
Quartz

find quote
pecinko Offline
Donor
Posts: 3,773
Joined: Dec 2008
Reputation: 51
Location: Prague / Belgrade
Post: #49
New one

vdrfan Wrote:https://github.com/xbmc/xbmc/commit/44cb...400d17696d adds the boolean infolabel Slideshow.IsActive.

My skins:

Amber
Quartz

find quote
pecinko Offline
Donor
Posts: 3,773
Joined: Dec 2008
Reputation: 51
Location: Prague / Belgrade
Post: #50
pieh Wrote:Also: If anyone is using IntegerGreaterThan(Player.Volume,[...]) he will need to adjust values as Player.Volume range for integer operations has now range [0, 100] instead of [-60, 0] (this change is sideeffect of getting rid int -> text -> int conversion we were doing with IntegerGreaterThan)

Player.Volume is returning -60,0 for me in on OS X, 12.9.2011 build?

My skins:

Amber
Quartz

find quote
pecinko Offline
Donor
Posts: 3,773
Joined: Dec 2008
Reputation: 51
Location: Prague / Belgrade
Post: #51
pieh Wrote:Added partially watched info:
boolean condition: ListItem.IsResumable
and text label / numeric value (for progress controls / IntegerGreaterThan): ListItem.PercentPlayed (range [0, 100])

It seams that ListItem.IsResumable is updated on Window open/reload not immediately like ListItem.Overlay. Is this by design or can I hope that it will change?

My skins:

Amber
Quartz

find quote
ronie Offline
Team-Kodi Member
Posts: 9,153
Joined: Jan 2009
Reputation: 157
Post: #52
pecinko Wrote:Player.Volume is returning -60,0 for me in on OS X, 12.9.2011 build?

it will still return a value on the [-60 - 0] scale when used with $INFO[]

only when using it with an IntegerGreaterThan() comparison it'll be on a [0 - 100] scale.

Always read the Kodi online-manual, FAQ and search the forum before posting.
Do not PM or e-mail Team-Kodi members directly asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting please make sure you read this first.
find quote
pecinko Offline
Donor
Posts: 3,773
Joined: Dec 2008
Reputation: 51
Location: Prague / Belgrade
Post: #53
ronie Wrote:it will still return a value on the [-60 - 0] scale when used with $INFO[]

only when using it with an IntegerGreaterThan() comparison it'll be on a [0 - 100] scale.

Thanks.

I thought that we got some user friendly labels (0-100) :-(

My skins:

Amber
Quartz

find quote
ronie Offline
Team-Kodi Member
Posts: 9,153
Joined: Jan 2009
Reputation: 157
Post: #54
pecinko Wrote:Thanks.

I thought that we got some user friendly labels (0-100) :-(

see:
https://github.com/xbmc/xbmc/pull/236

Always read the Kodi online-manual, FAQ and search the forum before posting.
Do not PM or e-mail Team-Kodi members directly asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting please make sure you read this first.
find quote
pecinko Offline
Donor
Posts: 3,773
Joined: Dec 2008
Reputation: 51
Location: Prague / Belgrade
Post: #55
ronie Wrote:see:
https://github.com/xbmc/xbmc/pull/236

Thanks a lot. I'll just hide the label. Geeks can mod a skin to show decibels :-)

My skins:

Amber
Quartz

find quote
pieh Offline
Team-Kodi Member
Posts: 672
Joined: Aug 2010
Reputation: 13
Location: Poland
Post: #56
it's just for IntegerGreaterThan, using Player.Volume in label will still display "-60.0 dB"

Always read the XBMC online-manual, FAQ and search the forums before posting.
Do NOT e-mail Team-XBMC members asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting, make sure you read this first

My previous forum/trac nickname: grajen3
find quote
ingeon Offline
Member
Posts: 86
Joined: Jan 2010
Reputation: 0
Location: SouthAfrica
Post: #57
edit: off-topic.
please use the feature suggestion section on the forum.

XBMC 12.3 Windows 7 x64
OpenELEC - Generic x86_64 v3.2.4
OpenELEC - Raspberry Pi v2.99.4 (3.0 RC 4)
Ember media manger 1.3.0.20 (thx DanCooper)
Media Companion v3.596b
Rashad TVRenamer 0.7 Beta 2/EPnamer v1.45
Calibre-ebook

(This post was last modified: 2011-10-26 21:40 by ingeon.)
find quote
ronie Offline
Team-Kodi Member
Posts: 9,153
Joined: Jan 2009
Reputation: 157
Post: #58
this commit: https://github.com/xbmc/xbmc/commit/f4bb...893fc26662

adds 2 new dialogs to xbmc:

DialogPeripheralManager.xml
DialogPeripheralSettings.xml

Always read the Kodi online-manual, FAQ and search the forum before posting.
Do not PM or e-mail Team-Kodi members directly asking for support. Read/follow the forum rules.
For troubleshooting and bug reporting please make sure you read this first.
find quote
`Black Offline
Team-Kodi Member
Posts: 2,430
Joined: Apr 2009
Reputation: 72
Location: Germany
Post: #59
Where do they appear?

[Image: xp1080-21.png]
find quote
Hitcher Online
Skilled Skinner
Posts: 10,739
Joined: Aug 2007
Reputation: 97
Location: Eastleigh, UK
Post: #60
This is what they look like in Confluence -

DialogPeripheralManager.xml

[Image: screenshot002eq.jpg]

DialogPeripheralSettings.xml

[Image: screenshot003ki.jpg]

I'm guessing it's for the USB - HDMI-CEC Adapter
find quote
Post Reply