[PATCH] Global AV delay support via advancedsettings.xml

@DDDamian: have you seen this thread: http://forum.xbmc.org/showthread.php?tid=82896? I wonder if there's something similar going on. I guess I could try remuxing a file that lags to see if it makes it any better.

Hi negge - I do know some of the background to it, and the issues with the time stamps. It's part of the joy of so many rippers/muxers/recoders being out there that it's hit and miss as to whether the sync frames are correct.

If you have the patience to try remuxing some problematic files, please do. The more info on what works/what doesn't the better!

dude its all files, trust me i have spend 100s of hours beating my head against the wall on this one, save the brain cells (and your walls) no other apps do it (some might on files thatactually do have a timestamp problem but not to the consisitanty of xbmc this patch totally fixes it it just has a small bug about clearing its settings from memory so if you use it for anything other then 250ms 24htz oos bug its pointless but.... hey it works

https://github.com/xbmc/xbmc/pull/713

New patch?

Tried to apply this :

https://github.com/xbmc/xbmc/pull/713.patch


got a compile error

Quote: APPLY PATCH: packages/mediacenter/xbmc/patches/xbmc-1fef727-002-av-delay.patch
patching file xbmc/cores/VideoRenderers/RenderManager.cpp
patching file xbmc/cores/VideoRenderers/RenderManager.h
patching file xbmc/cores/dvdplayer/DVDPlayerVideo.cpp
Hunk #1 succeeded at 1110 (offset -3 lines).
patching file xbmc/settings/AdvancedSettings.cpp
Hunk #1 succeeded at 534 (offset -1 lines).
Hunk #2 succeeded at 1087 (offset -3 lines).
patching file xbmc/settings/AdvancedSettings.h
Hunk #3 succeeded at 313 (offset -1 lines).
patching file xbmc/cores/VideoRenderers/RenderManager.cpp
patching file xbmc/cores/VideoRenderers/RenderManager.h
patching file xbmc/cores/dvdplayer/DVDPlayerVideo.cpp
Hunk #1 succeeded at 1110 (offset -3 lines).
patching file xbmc/settings/AdvancedSettings.cpp
Hunk #1 succeeded at 535 (offset -1 lines).
Hunk #2 succeeded at 1090 (offset -3 lines).
patching file xbmc/settings/AdvancedSettings.h
Hunk #3 succeeded at 314 (offset -1 lines).
patching file xbmc/cores/VideoRenderers/RenderManager.cpp
patching file xbmc/settings/AdvancedSettings.cpp
Hunk #1 succeeded at 534 (offset -1 lines).
patching file xbmc/video/windows/GUIWindowFullScreen.cpp
patching file xbmc/cores/VideoRenderers/RenderManager.cpp
patching file xbmc/cores/VideoRenderers/RenderManager.h
patching file xbmc/cores/dvdplayer/DVDPlayer.cpp
Hunk #1 succeeded at 2424 (offset -9 lines).
patching file xbmc/cores/dvdplayer/DVDPlayerAudio.cpp
patching file xbmc/cores/dvdplayer/DVDPlayerVideo.cpp
Hunk #1 succeeded at 1110 (offset -3 lines).
patching file xbmc/settings/AdvancedSettings.cpp
Hunk #1 succeeded at 370 (offset -1 lines).
Hunk #2 succeeded at 575 (offset -1 lines).
Hunk #3 succeeded at 1091 (offset -3 lines).
patching file xbmc/video/windows/GUIWindowFullScreen.cpp
patching file xbmc/cores/dvdplayer/DVDPlayerAudio.cpp
patching file xbmc/cores/dvdplayer/DVDPlayerVideo.cpp
Hunk #1 succeeded at 1108 (offset -3 lines).
patching file xbmc/cores/VideoRenderers/RenderManager.cpp
patching file xbmc/cores/VideoRenderers/RenderManager.h
patching file xbmc/cores/dvdplayer/DVDPlayer.cpp
Hunk #1 succeeded at 2424 (offset -9 lines).
patching file xbmc/cores/dvdplayer/DVDPlayerVideo.cpp
Hunk #1 succeeded at 1108 (offset -3 lines).
patching file xbmc/settings/AdvancedSettings.cpp
Hunk #1 succeeded at 370 (offset -1 lines).
Hunk #2 FAILED at 540.
Hunk #3 succeeded at 1047 (offset -3 lines).
1 out of 3 hunks FAILED -- saving rejects to file xbmc/settings/AdvancedSettings.cpp.rej
patching file xbmc/settings/AdvancedSettings.h
Hunk #3 succeeded at 314 (offset -1 lines).
make: *** [release] Error 1

Try this one, this is a single patch of all the commits in that pull: http://pastebin.com/rxjDVyL3. Or you can also get this single diff here: https://github.com/xbmc/xbmc/pull/713.diff

Also make sure to change your advancedsettings as described in the pull before testing. No new functionality in this patch, just a refactor. But it is always nice to have test reports.

Ok, I'll test this, but it's still not compiling for either :

I'm using the patches in openelec and it's prerty easy I have to drop this in a file and it compiles, butit chokes.

Trying to applythis directly on 1fef727 xbmc beta 3 main

Anyways, adding .diff rather than .patch to the url gives this :

APPLY PATCH: packages/mediacenter/xbmc/patches/xbmc-1fef727-002-av-delay.patch
patching file xbmc/cores/VideoRenderers/RenderManager.cpp
patching file xbmc/cores/VideoRenderers/RenderManager.h
patching file xbmc/cores/dvdplayer/DVDPlayer.cpp
Hunk #1 succeeded at 2424 (offset -9 lines).
patching file xbmc/cores/dvdplayer/DVDPlayerVideo.cpp
Hunk #1 succeeded at 1108 (offset -3 lines).
patching file xbmc/settings/AdvancedSettings.cpp
Hunk #1 FAILED at 540.
Hunk #2 succeeded at 1046 (offset -3 lines).
1 out of 2 hunks FAILED -- saving rejects to file xbmc/settings/AdvancedSettings.cpp.rej
patching file xbmc/settings/AdvancedSettings.h
Hunk #3 succeeded at 313 (offset -1 lines).
make: *** [release] Error 1

Something in mainline is conflicting with the diff. Maybe something was changed in between that does not allow the patch to be applied directly to current master. You can just insert the rejected part manually.

You can't just insert the rejected part manually as far as I know it unpacks the source just runs the patches and aborts.

It's actually pretty slick and they've done a cool job of programming the build process.

Is your branch that different from master?

I did some testing the other day but I haven't found anything by looking at the logs as to what is causing the delay on some files and not on some others. I also tried remuxing a video that was known to have issues with the newest mkvmerge but it had no effect.

What someone should try:

1. Find a video clip that has delay issues.
2. Try any of the following:

* remux with different options in mkvmerge
* remuxing to a different container (like AVI)
* playing file without hardware acceleration (to rule out whether it's e.g. a VDPAU-specific issue)
* anything

There must be something that is causing this aside from the refresh rate change as I have a few videos which do not have any issues even though they play at 24fps.

https://github.com/xbmc/xbmc/pull/713#is...nt-4162815

Quote:elupus merged commit 9a60f0c into xbmc:master from a11599:audiodelay 6 minutes ago

Does this mean the feature has now hit eden?