Should we be doing a pull request when submitting a patch?

Harry Muscle · 2011-03-22 20:04

Now that we are working with GIT and can have our own fork of the repo on github, should we be submitting a Pull Request when we submit a patch? Or should we do things the old way of just uploading the patch to the ticket associated with the patch? Or maybe both?

Thanks,
Harry

**davilla** · 2011-03-22 21:12

Pull Request is preferred.

Harry Muscle · 2011-03-23 00:40

davilla Wrote:Pull Request is preferred.

Perfect.

Thanks,
Harry

Harry Muscle Fan Posts: 505 Joined: Nov 2006 Reputation: 0	2011-03-22 20:04 Post: #1 Now that we are working with GIT and can have our own fork of the repo on github, should we be submitting a Pull Request when we submit a patch? Or should we do things the old way of just uploading the patch to the ticket associated with the patch? Or maybe both? Thanks, Harry
	find quote

davilla Team-XBMC Developer Posts: 10,403 Joined: Feb 2008 Reputation: 58	2011-03-22 21:12 Post: #2 Pull Request is preferred. MediaInfo : http://mediainfo.sourceforge.net/ Do not e-mail XBMC-Team members directly asking for support. Read/follow the forum rules.
	find quote

Harry Muscle Fan Posts: 505 Joined: Nov 2006 Reputation: 0	2011-03-23 00:40 Post: #3 davilla Wrote:Pull Request is preferred. Perfect. Thanks, Harry
	find quote