Kodi Community Forum
New sort method (date taken) for Pictures - Printable Version

+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Development (https://forum.kodi.tv/forumdisplay.php?fid=32)
+--- Forum: Kodi Application (https://forum.kodi.tv/forumdisplay.php?fid=93)
+--- Thread: New sort method (date taken) for Pictures (/showthread.php?tid=156942)

New sort method (date taken) for Pictures - rubpa - 2013-02-20

I use my xbmcbuntu setup to view my picture collection often and have always wanted to see pictures in the order of "date taken". I've explained more here.

I started exploring the xbmc code for the first time and feel that I can contribute to developing this feature. I tried a minor change in windows by modifying CPictureInfoTag::ToSortable() to fill sortable[FieldDate] with the exif date and the overall experience of watching photos of an event is significantly better now. Of course, this is good as a hack but not the best method for production code.

I need your opinion on this. I feel the best option is to create a new "sort method" - may be called "Date Taken". This sort method shall be enabled only for the Pictures view. What do you think? Based on inputs I get here I will try and develop this.

Thanks!

RE: New sort method (date taken) for Pictures - Xycl - 2013-02-22

Please do it.
Because then I can use it for MyPicsDB.

RE: New sort method (date taken) for Pictures - rubpa - 2013-02-23

Xycl, do you think this is the best approach - a new sort method?

I plan to do the following changes:
  1. add a new sort method "Date Taken"
  2. for MyPicsDB, I don't need to do anything because filling the exiftime is already well handled through the python interface
Looks good?

RE: New sort method (date taken) for Pictures - Robotica - 2013-02-23

this is a much wanted feature. I think the way you propose (new sort method only for pictures) is the way forward..

RE: New sort method (date taken) for Pictures - Robotica - 2013-02-27

And a related ticket: http://trac.xbmc.org/ticket/10519

And if you'r working on this; mind this PR: https://github.com/xbmc/xbmc/pull/2294

RE: New sort method (date taken) for Pictures - rubpa - 2013-03-02

Thanks Robotica.

Can you please help me in submitting the PR? I'm not sure if I need to merge all the changes in xbmc master since I forked about a week ago. I guess this is called rebase but I could not figure out how to do it. I understand that the PR you are pointing out modifies the same code files that I touch.

My dev is visible here: https://github.com/rubpa/xbmc/tree/picsort . Help me submit the PR.

RE: New sort method (date taken) for Pictures - Montellese - 2013-03-03

Code:
git pull --rebase upstream master
will pull in all the commits done in the upstream/master repository since you forked it. This assumes that you added the XBMC git repo as a remote called "upstream".

RE: New sort method (date taken) for Pictures - rubpa - 2013-03-06

Thanks Montellese. It helped. I understood git a little more too.

I've done the rebase and submitted the PR. The pull request for this dev is https://github.com/xbmc/xbmc/pull/2377

Thank you all!