+- Kodi Community Forum (https://forum.kodi.tv)
+-- Forum: Development (https://forum.kodi.tv/forumdisplay.php?fid=32)
+--- Forum: Scrapers (https://forum.kodi.tv/forumdisplay.php?fid=60)
+--- Thread: differences between imdb and moviedb - skinning problem (/showthread.php?tid=75036)
Pages:
1
2
output differences between imdb and moviedb scraper - skinning problem - Jeroen - 2010-06-03
I'm running into a bit of trouble skinning because of a difference between the imdb and moviedb scrapers regarding movie duration.
The moviedb scraper outputs the duration in numbers only, so I feel I have to give the duration info label a suffix like "minutes" or "min"
No biggie in itself, except that the imdb scraper output has "min" already attached. And of course often times extra information for different countries.
So I can't attach "min" after that because, that would look silly. There is no way I can make the infolabel conditional based on the selected scraper.
So, any chance the moviedb scraper's output can be adjusted so "min" is appended to the duration output?
- mkortstiege - 2010-06-03
Yeah, ideally we should just scrape the numeric duration and provide the unit as a localized string. Mind creating a new feature request ticket for this?
- Jeroen - 2010-06-03
Sure, ticket added
Thanks
- jmarshall - 2010-06-03
IIRC there's some code in StringUtils to take care of the "min" thing that imdb adds. It should ideally be normalized in the database, however.
Cheers,
Jonathan
- mkortstiege - 2010-06-04
FYI, r30825 takes care of that one. I've also updated most of the scrapers to reflect recent changes.
- Jeroen - 2010-06-04
sweet
thanks a lot!
- mkortstiege - 2010-06-04
You're welcome. Note, there's still an issue with stacked files that i am working on atm.
- mcborzu - 2010-06-08
Just wanted to 2x check...
You guys are also stripping the extra info out of .nfo's? I was wondering how we(skinners) would deal with people who use Ember...
On 30851 I just noticed all my runtimes which were scrapped using Ember used to show:
1 hrs and 44 mins
now show:
107
So no matter what people use, internal or external scrappers, we will now just get the duration outputted in minutes only?
- ronie - 2010-06-08
mcborzu Wrote:Just wanted to 2x check...
You guys are also stripping the extra info out of .nfo's? I was wondering how we(skinners) would deal with people who use Ember...
On 30851 I just noticed all my runtimes which were scrapped using Ember used to show:
1 hrs and 44 mins
now show:
107
So no matter what people use, internal or external scrappers, we will now just get the duration outputted in minutes only?
true, xbmc itself now determines the length of the video and ignores any duration info provided by scrapers as well as .nfo files.
in your skin, just add $LOCALIZE[12391] if you want the 'Minutes' string back.
- D0nR0s4 - 2010-06-08
mcborzu Wrote:Just wanted to 2x check...
You guys are also stripping the extra info out of .nfo's? I was wondering how we(skinners) would deal with people who use Ember...
On 30851 I just noticed all my runtimes which were scrapped using Ember used to show:
1 hrs and 44 mins
now show:
107
So no matter what people use, internal or external scrappers, we will now just get the duration outputted in minutes only?
It seems so, but if, I think its for the better, because it makes it unified. Maybe a possibility in skinning to ouput as minutes or hours and minutes could be implemented?
- jmarshall - 2010-06-08
The skinner can already do that.
- mcborzu - 2010-06-09
jmarshall Wrote:The skinner can already do that.
How can I specify it to show 1 hr 33 min instead of 93...
- Maxoo - 2010-06-09
ronie Wrote:in your skin, just add $LOCALIZE[12391] if you want the 'Minutes' string back.
- mcborzu - 2010-06-09
The way I interpreted JM's response was there is a way like so:
ListItem.duration returns 93
and
ListItem.durationhrmin returns 1 hr and 33 min
Sort of like there is ListItem.Cast and ListItem.CastandRole
- jmarshall - 2010-06-09
ListItem.Duration(HH:MM) doesn't work?