[RELEASE] XBMC Subtitles - Addon Script

(2012-04-05 10:26)amet Wrote:  never heard of anyone trying to centralize addon data, nor did I hear any team members advising that it would be a good idea. correct me if I am wrong.

Well it is there, and if you just read the Wiki about it then it is nobody trying to say that you are not suppose to use the feature.....

(2012-04-05 10:26)amet Wrote:  there is more than one issue with multiple instances of XBMC opening the same files that are in there, my opinion is that it shouldn't be done.

Yes I can see that too. But what I think everybody wants is a centralized reading/writing of settings.xml, at least as I see it now but I havent been able to test it that much
And that shouldn't be that much of a problem.

(2012-04-05 10:26)amet Wrote:  besides, this has nothing to do with this addon, if the pathsubstitution is not handeled correctly then its a XBMC core issue but I think what you are seeing is just the incosistent logging... we save and open from a same location "sub_temp" in "__profile__ = xbmc.translatePath( __addon__.getAddonInfo('profile') ).decode("utf-8")"

There I think you are wrong, in the part of inconsistent logging at least. The first part I really couldn't say. But if you look at the log it saves the subtitile locally (it was an episode of Alcatraz) and then it opens the same file name (zipsubs.zip) from the centralized place, and that is an old episode of Burn Notice in that zipsubs.zip . (Row 1154-1158 and/or 1173-1176) in my OSX Log.

Now when I look at it a little bit more I see that it can really be a core XBMC issue. If I read the log correctly the substitution works as long as it is not files inside a zip-file. It is then it wont use the substitution?!.
Could you just do me the favor and look too see if that is correct please. Then I can take this problem to the right place

(2012-04-05 15:26)MatsF Wrote:  

(2012-04-05 10:26)amet Wrote:  never heard of anyone trying to centralize addon data, nor did I hear any team members advising that it would be a good idea. correct me if I am wrong.

Well it is there, and if you just read the Wiki about it then it is nobody trying to say that you are not suppose to use the feature.....

well, anyone can put it in there..I dont agree with it

(2012-04-05 15:26)MatsF Wrote:  

(2012-04-05 10:26)amet Wrote:  there is more than one issue with multiple instances of XBMC opening the same files that are in there, my opinion is that it shouldn't be done.

Yes I can see that too. But what I think everybody wants is a centralized reading/writing of settings.xml, at least as I see it now but I havent been able to test it that much
And that shouldn't be that much of a problem.

you want it, I dont , and I have 5 xbmc instances in the house.... its personal taste

(2012-04-05 15:26)MatsF Wrote:  

(2012-04-05 10:26)amet Wrote:  besides, this has nothing to do with this addon, if the pathsubstitution is not handeled correctly then its a XBMC core issue but I think what you are seeing is just the incosistent logging... we save and open from a same location "sub_temp" in "__profile__ = xbmc.translatePath( __addon__.getAddonInfo('profile') ).decode("utf-8")"

There I think you are wrong, in the part of inconsistent logging at least. The first part I really couldn't say. But if you look at the log it saves the subtitile locally (it was an episode of Alcatraz) and then it opens the same file name (zipsubs.zip) from the centralized place, and that is an old episode of Burn Notice in that zipsubs.zip . (Row 1154-1158 and/or 1173-1176) in my OSX Log.

Now when I look at it a little bit more I see that it can really be a core XBMC issue. If I read the log correctly the substitution works as long as it is not files inside a zip-file. It is then it wont use the substitution?!.
Could you just do me the favor and look too see if that is correct please. Then I can take this problem to the right place

it looks to me that it looks for the file in the right place,

it does say its "local" but in fact it is opening the SMB file(CFileSMB::Open), hence me saying that its logging issue rather than not substituting. looks like it fails extracting the file to the temp_location as it says that the zip file is correctly opened.

I think addon does everything correctly, it uses the same path for both, if its failing its core that is not handling it correctly.

I'm the guilty one who put "addon_data" as one of the possible sharable files/folders. I do know that not all add-ons in all situations will respect pathsubs due to how XBMC works, but in theory nothing bad should happen when sharing that folder (as opposed to guisettings.xml or any of the db's, where we know there will be issues). Or at the very least, I've never experienced any issues, and I have never heard of any issues other than some add-ons not sharing all data. Will try to note this on the wiki.

(2012-04-05 15:47)amet Wrote:  you want it, I dont , and I have 5 xbmc instances in the house.... its personal taste

I also have 5 instances and I dont understand how anyone wants to configure every addon in 5 places when it is possible to do it in one place and then it works on the other four places in the exact same way. And especially with XBMC Subtiles addon I cant see any reason to configure it in different ways on different clients.

(2012-04-05 15:47)amet Wrote:  it looks to me that it looks for the file in the right place,

Code:

07:51:11 T:2689590592   DEBUG: CFileSMB::Open - opened /Video/XBMC/Userdata/addon_data/script.xbmc.subtitles/sub_tmp/zipsubs.zip, fd=10000

it does say its "local" but in fact it is opening the SMB file(CFileSMB::Open), hence me saying that its logging issue rather than not substituting. looks like it fails extracting the file to the temp_location as it says that the zip file is correctly opened.

Code:

07:51:20 T:2689590592 WARNING: FileSmb::OpenForWrite() called with overwriting enabled! - smb://XBMC:xbmc@ASUSP5BVISTA/Video/XBMC/Userdata/addon%5fdata/script%2exbmc%2esubtitles/sub%5ftmp/720p%2eDIM/Burn%2eNotice%2e311%2e720p%2eDIM%2eVO%2eNOTAG%2esrt

I think addon does everything correctly, it uses the same path for both, if its failing its core that is not handling it correctly.

Well, it is exactly that I want to know. To me it also seems like it is the core (as I said). But I dont understand your example, I think you took the wrong rows in the log.
In row 1154 it saves the zip-file and that is local as you can see in the code below And when I look at the two zipsubs.zip the local one has the new srt-file and the one in the substituted directory has an old srt-file inside it, (Burn Notice). And when it tries to copy it to the movies-folder it looks in the central one again, and not finding it of course because it is not there.

Is this the core doing this?

I also want to thank you for answering all my annoying questions about this.
/Mats

(2012-04-06 01:42)Ned Scott Wrote:  I'm the guilty one who put "addon_data" as one of the possible sharable files/folders. I do know that not all add-ons in all situations will respect pathsubs due to how XBMC works, but in theory nothing bad should happen when sharing that folder (as opposed to guisettings.xml or any of the db's, where we know there will be issues). Or at the very least, I've never experienced any issues, and I have never heard of any issues other than some add-ons not sharing all data. Will try to note this on the wiki.

I think that was a really good idea to do that. Maybe we shouldn't continue this discussion in this thread but can you see if it is the XBMC core doing this wroing (looking at amets two rows of my log and my row in the end of my post above)?
The examples of this log is from my OSX client and I just want to tell you that it handles it differently on the Windows 7 client.

/Mats

What is the HTTP command for XBMC Subtitles button?

I'd like a button on XBMC iOS remote app that goes straight to XBMC Subtitles. At the moment I hae to move my mouse and click, and that's just too much when you're laying on sofa

Thanks

Subtitles downloading have stopped working on my system, did a reinstall but problem persists. Log here: http://pastebin.com/Zaz87WEW

(2012-04-09 00:37)madmalkav Wrote:  Subtitles downloading have stopped working on my system, did a reinstall but problem persists. Log here: http://pastebin.com/Zaz87WEW

^^ not a debug log, read the instructions again

My bad, sorry, here you have http://pastebin.com/eJ6wbw1M and http://pastebin.com/6NzNsVHe

Hello
I want to add subtitles in XBMC addon addresses:
http://subs.sab.bz/
http://subsunacs.net/

If you can show me some guidance I would be very grateful, as Bulgarian subtitles are very small with current sites.