Posts: 589
Joined: Jun 2009
Reputation:
28
It would be really useful, especially with the speed increases to the DX shaders to be able to disable DXVA2 on SD resolutions. Meaning lanczos3optimized etc can be used to scale the video up.
I think it would be great to be able to do it on a per-codec basis Perhaps something like this:
<DXVA2MPG2>true</DXVA2MPG2>
<DXVA2MPG2SD>false<DXVA2MPG2SD>
<DXVA2H264>true</DXVA2H264>
<DXVA2H264SD>false<DXVA2H264SD>
<DXVA2VC1>true</DXVA2VC1>
<DXVA2VC1SD>false<DXVA2VC1SD>
Defining SD would be tricky, but I would imagine, anything with a horizontal resolution of less than - 800 would work. As then 4:3 720p vids would get dxva2. And I doubt theres many 720p vids narrower than 4:3.
Alternatively perhaps a:
<DXVA2MinimumHorizontal>800</DXVA2MinimumHorizontal>
A vertical setting might be useles as 1:2.35 720p videos are 1280*544 ish, and SD dvds are 720*576 in the case of PAL, so there is overlap vertically, but typically not with horizontal resolutions.
Again, only an idea.
Posts: 2,752
Joined: Dec 2008
Reputation:
23
bobo1on1
cheapass Team-XBMC Developer
Posts: 2,752
How about hooking up the scalers to the dxva output instead.
Posts: 1,286
Joined: Apr 2010
Reputation:
94
CrystalP
Team-Kodi Developer
Posts: 1,286
Yes, that's the plan but feature freeze and the next release are looming so don't bet on it...
Posts: 589
Joined: Jun 2009
Reputation:
28
ok, thanks for keeping us mortals up-to-date.
Posts: 589
Joined: Jun 2009
Reputation:
28
Does Nvidia have a DXVA scaler which is HQ? Because with bilinear it's not so great. Fine for 720p -> 1080p, but SD really shows the jaggies.
I can grab screens if you're interested.
Posts: 1,286
Joined: Apr 2010
Reputation:
94
CrystalP
Team-Kodi Developer
Posts: 1,286
2010-07-12, 05:47
(This post was last modified: 2010-07-12, 05:52 by CrystalP.)
Don't know, I don't have one. nVidia with VP4 is supposed to get a better quality scaler than previous generations.
I'll post the patch for people to try it and give feedback.
You can compare yourself - play with DXVA, grab. Play with Lanczos3 and no DXVA, grab. Compare.
edit: out of curiosity, yes I'd like to see side by side nVidia DXVA scaler and Lanczos3. Please specifiy which kind of nVidia you have.
Posts: 2,752
Joined: Dec 2008
Reputation:
23
bobo1on1
cheapass Team-XBMC Developer
Posts: 2,752
ION-DXVA looks like bilinear to me.
Posts: 589
Joined: Jun 2009
Reputation:
28
2010-07-12, 18:06
(This post was last modified: 2010-07-12, 18:08 by neil.j1983.)
I would agree, so the ion uses bilinear (or something similar) and the gt240 and hd4550 use something more like lanczos but all currently come under a "bilinear" on the gui/osd, is that an issue? Should the name be something more loosely defined?
Posts: 589
Joined: Jun 2009
Reputation:
28
2010-07-13, 13:45
(This post was last modified: 2010-07-13, 15:38 by neil.j1983.)
If possible, I would like the devs to implement the dxvadecoder -> shaders. As this would allow dxva decoding and nice resizing, even wih 720p scaled to 1080p content.
I think it would be great to be able to switch between auto bilinear,bicubic,lanczos2,lanczos3optimized and dxva scaling methods. That way they are available for all videos.
It would be a more harmonious approach than currently having only 'bilinear' under dxva and all the others for software. I suppose it would be a little more like the linux approach.
But it's not really up to me.
Posts: 589
Joined: Jun 2009
Reputation:
28
CrystalP, is there any chance you will patch in support for the higher quality scalers when using dxva decoding?
If you aren't going to commit it, do you have a .diff which I could compile with myself?