Movie sets not working for smart playlists?

barramundi · 2011-09-02 00:54

Hi.
I am not able to see movie sets for smart playlist since a couple of days. Movies inside a set are presented now individually if i use smart playlists and that was not happening a week ago (or so). I am using nighties.

Has anyone noticed this? Any tip to fix?

Thanks in advance Smile

**spiff** · 2011-09-02 11:06

yes, it was changed. it's impossible to satisfy everybody here, some wants it one way, others the opposite...

barramundi · 2011-09-02 19:58

Oh, i see. As usual, i was in the wrong 50% group. My fully customized home menu is full of smart playlists, with lots of (now broken) movie sets.

Would you or someone be so kind to point me to the relevant code sources responsibles of this functionality? Time for me to learn.

Thanks for the input spiff, and for the good work.
Farewell

----
Edit. Got the answer. Commit with chabges were made on 26-Aug, in xbmc/video/VideoDatabase.cpp

isamu.dragon · 2011-09-06 05:27

why not have an option on whether or not to view Movie Sets when setting up smart Playlists

barramundi · 2011-09-06 15:37

isamu.dragon Wrote:why not have an option on whether or not to view Movie Sets when setting up smart Playlists

That is imo the perfect solution, some kind of flag to control that feature.

**vdrfan** · 2011-09-06 15:50

IMO this would over-complicate things. The majority of users is not using sets. Furthermore a set does not necessarily have similar (smartplaylist-wise) values (eg. studio, rating etc..).

barramundi · 2011-09-06 18:39

vdrfan Wrote:IMO this would over-complicate things. The majority of users is not using sets. Furthermore a set does not necessarily have similar (smartplaylist-wise) values (eg. studio, rating etc..).

Yes, a more complicate configuration would be needed if we are looking for a complete solution, but a simple flag is enough to mantain the two worlds (how it was before and how it is now).

I sadly agree vdrfan, seems people doesn´t use movie sets. Sad

**vdrfan** · 2011-09-06 18:47

Even though i think it's not worth the hassle .. Patch welcome Wink

This is a good candidate to be discussed on a Pull-Request.

**Martijn** · 2011-09-07 20:50

To bad i don't program. I also would love the sets back in smartlists. Simple on of option would suffise.

isamu.dragon · 2011-09-08 08:40

vdrfan Wrote:IMO this would over-complicate things. The majority of users is not using sets. Furthermore a set does not necessarily have similar (smartplaylist-wise) values (eg. studio, rating etc..).

If most don't use sets, my guess is that the ones who do want to see them in their smart playlists. They Just don't want the ones irrelevant to their Playlist (e.g. Batman (1989)(480p) showing up for a HD Playlist).

An easy solution for smart playlists is a Boolean "Flatten Movie Sets" in the smart playlist selection.

The Boolean will work on a system of checking for the field <set></set>.
If <set></set> is present then It will show it the Set, if not then viewed as normal movie.

is this a reasonable request?

barramundi Junior Member Posts: 17 Joined: Aug 2011 Reputation: 0	2011-09-02 00:54 Post: #1 Hi. I am not able to see movie sets for smart playlist since a couple of days. Movies inside a set are presented now individually if i use smart playlists and that was not happening a week ago (or so). I am using nighties. Has anyone noticed this? Any tip to fix? Thanks in advance
	find quote

spiff Grumpy Bastard Developer Posts: 12,174 Joined: Nov 2003 Reputation: 82	2011-09-02 11:06 Post: #2 yes, it was changed. it's impossible to satisfy everybody here, some wants it one way, others the opposite... Always read the XBMC online-manual, FAQ and search the forum before posting. Do not e-mail XBMC-Team members directly asking for support. Read/follow the forum rules. For troubleshooting and bug reporting please make sure you read this first.
	find quote

isamu.dragon Posting Freak Posts: 949 Joined: Feb 2009 Reputation: 4 Location: T.A.R.D.I.S.	2011-09-06 05:27 Post: #4 why not have an option on whether or not to view Movie Sets when setting up smart Playlists XBMC Server/Client: Database Type: MySQL OS: WIN7 64-Bit/XBMCuntu CPU: i7/Intel Atom (Dual Core) GPU: Nvidia GeForce GTS450/Nvidia Ion RAM: 12GB/2GB (512MB GPU) XBMC Version: Frodo 12.2/XBMCbuntu Frodo 12.2Skin: Aeon Nox
	find quote

barramundi Junior Member Posts: 17 Joined: Aug 2011 Reputation: 0	2011-09-06 15:37 Post: #5 isamu.dragon Wrote:why not have an option on whether or not to view Movie Sets when setting up smart Playlists That is imo the perfect solution, some kind of flag to control that feature.
	find quote